[Security Solution] [Cases] Remove dynamic mappings for 3rd party cases mappings #97754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
cnasikas
approved these changes
Apr 21, 2021
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Apr 21, 2021
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Apr 21, 2021
stephmilovic
added a commit
that referenced
this pull request
Apr 21, 2021
stephmilovic
added a commit
that referenced
this pull request
Apr 21, 2021
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Apr 21, 2021
|
Since this went into the 7.12 branch I took care of backporting it to 7.13, since the 7.x backport was merged after the new 7.13 branch was created. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #97661
Meta https://github.com/elastic/sdh-security-team/issues/121
For cases mappings to third party connectors, we have "preferred fields" to map to for each 3rd party unless the user had another field selected as required and our preferred field is not required. However, the action executor did not allow dynamic fields for the mappings, causing a bug.
The bug has been fixed by only mapping to our preferred fields. If the user has a required field and they try posting from Cases, they will get an error from the third party telling them a case was made without all required fields, hopefully leading the user to make the fields non-required
Note: dynamic fields will actually be a thing in the future when we have bidirectionality
Checklist