Skip to content

Conversation

@kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

* [ML] Moving file data vizualizer to file upload plugin

* removing maps plug dependency

* fixing imports

* small refactor

* adding missing endpoints

* fixing translations

* fxing table controls

* fixing types and disabling geo point test

* actually disabling geo point test

* making endpoints internal

* moving UI code to separate plugin

* enabling maps integration

* cleaning up dependencies

* fixing translation ids

* moving analyze file endpoint out of file upload plugin

* fixing transtations issues

* refactor for lazy loading of component

* updating limits

* updating plugin asciidoc

* code clean up

* further clean up

* adding comment

* fixing really obvious CI error

* removing commented out include

* reenabling geo point test

* fixing incorrectly changed import

* removing ml from labels and identifiers

* renaming function

* moving analyse file endpoint to file upload plugin

* reverting import path changes

* adding esUiShared back in

* fixing navigation tabs alignment in basic license

* adding key to tab wrapper

* reverting test label

* further removal of ml references

* removing ml label from more identifiers

* fixing tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Apr 20, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) April 20, 2021 21:20
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fileDataVisualizer - 178 +178
ml 1803 1732 -71
total +107

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fileDataVisualizer - 1.0MB ⚠️ +1.0MB
fileUpload 789.1KB 789.1KB +5.0B
ml 6.0MB 5.9MB -155.6KB
total +881.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fileDataVisualizer - 11.8KB +11.8KB
fileUpload 14.0KB 15.0KB +1014.0B
ml 68.9KB 68.5KB -409.0B
total +12.4KB
Unknown metric groups

API count

id before after diff
fileDataVisualizer - 19 +19
fileUpload 180 115 -65
total -46

API count missing comments

id before after diff
fileDataVisualizer - 19 +19
fileUpload 180 115 -65
total -46

API count with any type

id before after diff
fileUpload 6 4 -2

async chunk count

id before after diff
fileDataVisualizer - 1 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@kibanamachine kibanamachine merged commit 2a4b94d into elastic:7.x Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants