Update elasticsearch client version #97360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
v8.0.0
release_note:skip
💔 Build Failed
Failed CI Steps
Metrics [docs]
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Apr 19, 2021
ymao1
approved these changes
Apr 19, 2021
afharo
reviewed
Apr 19, 2021
| @@ -40,7 +40,7 @@ describe('ElasticIndex', () => { | |||
| return elasticsearchClientMock.createSuccessTransportRequestPromise({ | |||
| [index]: { | |||
| aliases: { foo: index }, | |||
| mappings: { dynamic: 'strict', properties: { a: 'b' } }, | |||
| mappings: { dynamic: 'strict', properties: { a: 'b' } as any }, | |||
There was a problem hiding this comment.
should we fix the mocked result instead of casting it as any? { a: 'b' } doesn't seem to fit any mapping definition.
| @@ -813,7 +812,7 @@ export const updateAndPickupMappings = ( | |||
| .putMapping({ | |||
| index, | |||
| timeout: DEFAULT_TIMEOUT, | |||
| body: mappings, | |||
| body: mappings as estypes.TypeMapping, | |||
There was a problem hiding this comment.
should we @elastic/elasticsearch? The reason it's failing is that GenericProperty expects all properties to be mandatory.
wylieconlon
approved these changes
Apr 19, 2021
1 task
|
closed in favour of #98266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
@elastic/elaticsearchto the nextcanaryversion and fix type errors.