Skip to content

add FTR test for aborted requests error name #97086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 19, 2021
Merged

add FTR test for aborted requests error name #97086

merged 8 commits into from
Apr 19, 2021

Conversation

@pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Apr 14, 2021 •
edited
Loading

Summary

Fix #51406

Checklist

@pgayvallet pgayvallet marked this pull request as ready for review April 14, 2021 12:17
@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.14.0 labels Apr 14, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 14, 2021

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet requested a review from a team April 14, 2021 12:28
mshustov
mshustov approved these changes Apr 19, 2021
View reviewed changes
test/plugin_functional/plugins/core_http/public/plugin.tsx Outdated
abortController.abort();

try {
await http.get('/api/core_http/never_reply', { signal: abortController.signal });
Copy link
Contributor

@mshustov mshustov Apr 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it even perform a request if you pass the aborted signal? Maybe we should call abort() after the request has been sent?

Copy link
Contributor Author

@pgayvallet pgayvallet Apr 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request object is created, but you're right, I'm not sure it goes further than readyState 0 when aborting before the call. In doubt, adapted in 86a6dd2

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 19, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit f1bc11e into elastic:master Apr 19, 2021
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Apr 19, 2021
@pgayvallet
add FTR test for aborted requests error name (elastic#97086)
a2ae51f 
* add FTR test for aborted requests error name

* delete unused file

* wait for the request to fire before cancellation
@pgayvallet pgayvallet mentioned this pull request Apr 19, 2021
Merged
pgayvallet added a commit that referenced this pull request Apr 19, 2021
@pgayvallet
add FTR test for aborted requests error name (#97086) (#97484)
1c553b7 
* add FTR test for aborted requests error name

* delete unused file

* wait for the request to fire before cancellation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bamieh Bamieh Bamieh approved these changes

+1 more reviewer

@mshustov mshustov mshustov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Core HTTP fetch service doesn't return AbortError

5 participants

@pgayvallet @elasticmachine @kibanamachine @mshustov @Bamieh