Skip to content

Conversation

@walterra
Copy link
Contributor

@walterra walterra commented Apr 6, 2021

Combined backport of #91473 and #95797.

walterra added 2 commits April 6, 2021 16:01
Updates the canvas element assertion service and stabilizes tests.
…e being rounded to 0. (elastic#95797)

- Fix color assertion with risk of percentage being rounded to 0.
- Better naming of attributes of expected values.
- Adds assertions to use the sample size dropdown and randomize query switch.
@walterra walterra added backport This PR is a backport of another PR :ml labels Apr 6, 2021
@walterra walterra self-assigned this Apr 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra
Copy link
Contributor Author

walterra commented Apr 6, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.4MB 6.4MB +900.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra
Copy link
Contributor Author

walterra commented Apr 7, 2021

Flaky test runner succeeded:

@walterra walterra merged commit bf055e5 into elastic:7.12 Apr 7, 2021
@walterra walterra deleted the ml-backport-7-12-canvas-functional-tests branch April 7, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR :ml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants