Skip to content

Fix 7.12 migration fail if the "timepicker:quickRanges" is null #95767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2021
Merged

Fix 7.12 migration fail if the "timepicker:quickRanges" is null #95767

merged 4 commits into from
Apr 6, 2021

Conversation

@Dosant
Copy link
Contributor

@Dosant Dosant commented Mar 30, 2021

Summary

Fix #95616

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience release_note:fix v8.0.0 Team:AppServices v7.13.0 v7.12.1 labels Mar 30, 2021
@Dosant
Copy link
Contributor Author

Dosant commented Mar 30, 2021

@elasticmachine merge upstream

@Dosant Dosant marked this pull request as ready for review March 31, 2021 11:56
@Dosant Dosant requested a review from a team as a code owner March 31, 2021 11:56
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 31, 2021

Pinging @elastic/kibana-app-services (Team:AppServices)

@Dosant Dosant requested review from lizozom and rudolf March 31, 2021 11:56
TinaHeiligers
TinaHeiligers approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dosant
Copy link
Contributor Author

Dosant commented Apr 6, 2021

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Apr 6, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 6, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 2745a6e into elastic:master Apr 6, 2021
@Dosant Dosant mentioned this pull request Apr 6, 2021
Merged
Dosant added a commit to Dosant/kibana that referenced this pull request Apr 6, 2021
@Dosant
handle "null" in "timepicker:quickRanges" migration (elastic#95767)
3012503
Dosant added a commit to Dosant/kibana that referenced this pull request Apr 6, 2021
@Dosant
handle "null" in "timepicker:quickRanges" migration (elastic#95767)
f850fa0 
# Conflicts:
#	src/core/server/ui_settings/saved_objects/migrations.test.ts
@Dosant Dosant mentioned this pull request Apr 6, 2021
Merged
Dosant added a commit that referenced this pull request Apr 6, 2021
@Dosant
handle "null" in "timepicker:quickRanges" migration (#95767) (#96317)
a78c6d2 
# Conflicts:
#	src/core/server/ui_settings/saved_objects/migrations.test.ts
Dosant added a commit that referenced this pull request Apr 7, 2021
@Dosant @kibanamachine
handle "null" in "timepicker:quickRanges" migration (#95767) (#96313)
1bf810c 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rudolf rudolf rudolf approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

+1 more reviewer

@lizozom lizozom lizozom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Fixes for quality problems that affect the customer experience release_note:fix v7.12.1 v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7.12 Upgrade migrations fail if the advanced setting "timepicker:quickRanges" is null

6 participants

@Dosant @elasticmachine @kibanamachine @rudolf @lizozom @TinaHeiligers