[Discover][DocViewer] Fix adding columns from doc viewer table tab #95748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Feature:Discover
Member
Author
|
@elasticmachine merge upstream |
…olumns-from-doc-view
Member
Author
|
@elasticmachine merge upstream |
…olumns-from-doc-view
Member
Author
|
@elasticmachine merge upstream |
…olumns-from-doc-view
Member
Author
|
@elasticmachine merge upstream |
…olumns-from-doc-view
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
approved these changes
Apr 14, 2021
Contributor
majagrubic
left a comment
majagrubic
left a comment
There was a problem hiding this comment.
Tested in Chrome on Mac OSX, works as expected. Thanks for adding a test as well 👍
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Apr 14, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 14, 2021
…ax_primary_shard_size * 'master' of github.com:elastic/kibana: (99 commits) added missing optional chain for bracket notation (elastic#96939) [Discover][DocViewer] Fix toggle columns from doc viewer table tab (elastic#95748) [TSVB] Fix per-request caching of index patterns (elastic#97043) [Datatable] Fix filter cell flakiness (elastic#96934) Unskip heatmap suite and fixes flakiness (elastic#96941) [Fleet] Improve performance of data stream API (elastic#97058) [ML] Data Frame Analytics: remove beta badge (elastic#96977) [App Search] Migrate expanded rows for meta engines table in Engines Overview (elastic#96251) Instances latency distribution chart tooltips and axis fixes (elastic#95577) [Monitoring] Using primary average shard size (elastic#96177) [Workplace Search] Hide Kibana chrome on 3rd party connector redirects (elastic#97028) ## [Security Solution] Fixes `Exit full screen` and `Copy to cliboard` styling issues (elastic#96676) Index pattern field editor - Add warning on name or type change (elastic#95528) [App Search] Add small engine breadcrumb utility helper (elastic#96917) Copy esArchiver commands from ./reassign.ts to fix tests (elastic#97012) [Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (elastic#97011) Index patterns server - throw correct error on field caps 404 (elastic#95879) Use `EuiThemeProvider` in lists plugin tests and stories (elastic#96129) [npm] upgrade caniuse database (elastic#97002) chore(NA): moving @kbn/apm-utils into bazel (elastic#96227) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/serialization/policy_serialization.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Apr 14, 2021
…to-metrics-tab * 'master' of github.com:elastic/kibana: (61 commits) [Usage collection] Usage counters (elastic#96696) UI actions readme (elastic#96925) [TSVB] Enable brush for visualizations created with no index patterns (elastic#96727) [Data telemetry] Add Async Search to the tests (elastic#96693) added missing optional chain for bracket notation (elastic#96939) [Discover][DocViewer] Fix toggle columns from doc viewer table tab (elastic#95748) [TSVB] Fix per-request caching of index patterns (elastic#97043) [Datatable] Fix filter cell flakiness (elastic#96934) Unskip heatmap suite and fixes flakiness (elastic#96941) [Fleet] Improve performance of data stream API (elastic#97058) [ML] Data Frame Analytics: remove beta badge (elastic#96977) [App Search] Migrate expanded rows for meta engines table in Engines Overview (elastic#96251) Instances latency distribution chart tooltips and axis fixes (elastic#95577) [Monitoring] Using primary average shard size (elastic#96177) [Workplace Search] Hide Kibana chrome on 3rd party connector redirects (elastic#97028) ## [Security Solution] Fixes `Exit full screen` and `Copy to cliboard` styling issues (elastic#96676) Index pattern field editor - Add warning on name or type change (elastic#95528) [App Search] Add small engine breadcrumb utility helper (elastic#96917) Copy esArchiver commands from ./reassign.ts to fix tests (elastic#97012) [Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (elastic#97011) ...
kertal
added a commit
to kertal/kibana
that referenced
this pull request
May 3, 2021
kertal
added a commit
that referenced
this pull request
May 3, 2021
This was referenced May 11, 2021
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jul 8, 2021
kertal
added a commit
that referenced
this pull request
Jul 8, 2021
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Sep 3, 2021
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Sep 3, 2021
kertal
added a commit
that referenced
this pull request
Sep 3, 2021
kertal
added a commit
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores the ability to add/remove columns from Discover's doc viewer table tab by clicking on the "Toggle column in table" button.
This was broken a while ago (#42116), but worked due to Angular dark magic until recently (#89543) more columns state handling function were migrated to React (#89543). The React component didn't check for changes of columns.
Checklist
Test
Fixes #95390
Fixes #96695
Fixes #96694
Checklist