-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ML] Add search time runtime support for index based Data Visualizer #95252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0f5046f
[ML] Add runtime support from index pattern for data viz
qn895 c542ca5
Merge upstream/master into branch
qn895 1e708e1
[ML] move runtime mappings outside of aggregatableFields loop
qn895 a6ae3ce
[ML] Change arg name to runtimeMappings
qn895 705d84c
Merge remote-tracking branch 'upstream/master' into data-viz-runtime-…
qn895 861d28f
[ML] Fix dv full time range broken
qn895 97c5890
[ML] Fix dv broken with time range
qn895 b68e736
[ML] Add better error handling/transparency
qn895 54b62f8
[ML] Update to using estypes.RuntimeField
qn895 ce813f0
[ML] Update to use some shared common functions between ml and transform
qn895 db4123e
Revert "[ML] Update to use some shared common functions between ml an…
qn895 eaa2445
[ML] Disable context menu if no charts
qn895 3e4a475
Merge remote-tracking branch 'upstream/master' into data-viz-runtime-…
qn895 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { isPopulatedObject } from './object_utils'; | ||
| import { | ||
| RUNTIME_FIELD_TYPES, | ||
| RuntimeType, | ||
| } from '../../../../../src/plugins/data/common/index_patterns'; | ||
| import type { RuntimeField, RuntimeMappings } from '../types/fields'; | ||
|
|
||
| export function isRuntimeField(arg: unknown): arg is RuntimeField { | ||
| return ( | ||
| isPopulatedObject(arg) && | ||
| ((Object.keys(arg).length === 1 && arg.hasOwnProperty('type')) || | ||
| (Object.keys(arg).length === 2 && | ||
| arg.hasOwnProperty('type') && | ||
| arg.hasOwnProperty('script') && | ||
| (typeof arg.script === 'string' || | ||
| (isPopulatedObject(arg.script) && | ||
| Object.keys(arg.script).length === 1 && | ||
| arg.script.hasOwnProperty('source') && | ||
| typeof arg.script.source === 'string')))) && | ||
| RUNTIME_FIELD_TYPES.includes(arg.type as RuntimeType) | ||
| ); | ||
| } | ||
|
|
||
| export function isRuntimeMappings(arg: unknown): arg is RuntimeMappings { | ||
| return isPopulatedObject(arg) && Object.values(arg).every((d) => isRuntimeField(d)); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into this typeguard implementation I think it's worth writing some unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually the same implementation in Transform. Considering we have a few other PRs to switch to estypes, I'll leave this here for now so we can consolidate later.