[Maps] Show empty list when all saved maps in list deleted #95126

kindsun · 2021-03-23T00:18:56Z

Fixes #94638. The logic to redirect to a different URL was handled one component higher and only on initial load of the list component/page. This PR:

Removes the parent component which really wan't necessary
Consolidates duplicate saved map retrieval functionality
Eliminates an extra call to get saved maps
Preserves the redirect on nav to maps list when no maps are present, shows an empty list on delete w/o redirect

… one component down

elasticmachine · 2021-03-23T00:18:58Z

Pinging @elastic/kibana-gis (Team:Geo)

nreese · 2021-03-23T12:26:19Z

Is redirecting to new map required? I find it is kind of jolting. How about just showing an empty state like visualize and dashboard?

kindsun · 2021-03-23T14:42:21Z

Is redirecting to new map required? I find it is kind of jolting. How about just showing an empty state like visualize and dashboard?

Because we'd end up in an orphaned state/route situation. Maps currently redirects if a user lands on /app/maps/ and there are no saved maps. If a user deletes all Maps in the list, there's really nothing they can do there except create a map. Also, if a user were to refresh the page, it would redirect them to create a map. Mostly we should just be consistent regardless of which behavior we like better, either consistently redirect or consistently show an empty list.

nreese · 2021-03-23T14:53:59Z

I think that is ok to be on a route that would change if refreshed. As a user, I would not expect deleting the last map to re-route me to a new map. It just seems like a weird interaction.

Maybe we should re-consider the reroute to a new map if there are no map saved objects. Maybe we should strive for consistency with dashboard and visualize and always show a landing page.

kindsun · 2021-03-23T15:26:13Z

I think that is ok to be on a route that would change if refreshed. As a user, I would not expect deleting the last map to re-route me to a new map. It just seems like a weird interaction.

As a user, I would expect first consistency within the app and then more broadly consistency within Kibana. I think the weirdness you're referencing is equally applicable to the normal flow, I address this a little more below.

Maybe we should re-consider the reroute to a new map if there are no map saved objects. Maybe we should strive for consistency with dashboard and visualize and always show a landing page.

Agreed. I've been on the fence on whether or not the redirect makes sense for about as long as it's been in place. I've created a separate issue to address it #95178.

nreese · 2021-03-23T15:40:20Z

Agreed. I've been on the fence on whether or not the redirect makes sense for about as long as it's been in place. I've created a separate issue to address it #95178.

Thanks for opening the issue. I would think these are linked and the fix for #94638 is not to redirect but to have an empty listing view.

kindsun · 2021-03-23T15:50:27Z

Thanks for opening the issue. I would think these are linked and the fix for #94638 is not to redirect but to have an empty listing view.

I believe they're related but separate issues. The goal of the fix for #94638 should be to put the user into a usable and consistent route/state on delete of all maps saved objects. As it currently stands in the Maps app, we define that useable and consistent state of 0 map saved objects + route: /app/maps/ = redirect to /app/maps/map. Reconsidering the redirect behavior for this route is a broader topic triggerable from a few access points that ultimately amounts to a feature change. It should be a separate conversation from this fix.

kindsun · 2021-03-25T21:58:36Z

@elasticmachine merge upstream

…ect-on-list-delete

…njcaldwell/kibana into fix-missing-redirect-on-list-delete

…ect-on-list-delete

src/plugins/kibana_react/public/table_list_view/table_list_view.tsx

…ect-on-list-delete

…o empty list

lizozom

LGTM once green

kindsun · 2021-03-31T15:07:37Z

@elasticmachine merge upstream

x-pack/plugins/maps/public/routes/list_page/maps_list_view.tsx

kindsun · 2021-03-31T21:40:44Z

After some offline conversation I've rolled this back to just the changes to the table list view component. We can handle any further changes to the routing redirect when we address #94638

nreese

LGTM
code review

kibanamachine · 2021-03-31T23:30:19Z

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kibanaReact`	115.5KB	115.1KB	-334.0B

History

💚 Build #116596 succeeded d60b4c0
💔 Build #116555 failed da36a58
💔 Build #116404 failed 7ec46bf
💚 Build #115550 succeeded 60150c8
💔 Build #115516 failed 3d0edc4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…5126) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…96010) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…96009) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Aaron Caldwell added 2 commits March 22, 2021 17:45

Consolidate map search functionality into one function. Move redirect…

4fcecc3

… one component down

Remove unneeded parent component

9b0eaea

kindsun added release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.13.0 v7.12.1 labels Mar 23, 2021

kindsun requested a review from nreese March 23, 2021 00:18

Update i18n

800ba25

kindsun mentioned this pull request Mar 23, 2021

[Maps] Reconsider redirect to create new map when no saved maps exist #95178

Closed

Aaron Caldwell added 2 commits March 25, 2021 15:56

Update table list view to support showing empty list

6078afd

Redirect on nav to list page w/o maps. Don't redirect on delete

a6fc0f5

kindsun requested a review from a team as a code owner March 25, 2021 21:57

Merge branch 'master' into fix-missing-redirect-on-list-delete

b204710

kindsun changed the title ~~[Maps] Redirect to Maps app when all saved maps in list deleted~~ [Maps] Show empty list when all saved maps in list deleted Mar 25, 2021

Aaron Caldwell added 4 commits March 26, 2021 09:01

Merge remote-tracking branch 'upstream/master' into fix-missing-redir…

40c8956

…ect-on-list-delete

Merge branch 'fix-missing-redirect-on-list-delete' of github.com:aaro…

e0b2f8e

…njcaldwell/kibana into fix-missing-redirect-on-list-delete

Merge remote-tracking branch 'upstream/master' into fix-missing-redir…

3c25a8a

…ect-on-list-delete

Update snapshot

3d0edc4

kindsun requested a review from a team as a code owner March 26, 2021 15:37

Add missing semi-colon

60150c8

lizozom reviewed Mar 29, 2021

View reviewed changes

src/plugins/kibana_react/public/table_list_view/table_list_view.tsx Outdated Show resolved Hide resolved

Aaron Caldwell added 3 commits March 30, 2021 16:14

Merge remote-tracking branch 'upstream/master' into fix-missing-redir…

8d1c802

…ect-on-list-delete

Review feedback. Remove unused route of table list view and default t…

1195b12

…o empty list

Update dashboard test

7ec46bf

kindsun requested a review from lizozom March 31, 2021 01:50

lizozom approved these changes Mar 31, 2021

View reviewed changes

kindsun removed the request for review from a team March 31, 2021 15:08

kibanamachine and others added 3 commits March 31, 2021 11:19

Merge branch 'master' into fix-missing-redirect-on-list-delete

da36a58

i18n updates

dadb9b4

Remove space

d60b4c0

nreese reviewed Mar 31, 2021

View reviewed changes

x-pack/plugins/maps/public/routes/list_page/maps_list_view.tsx Outdated Show resolved Hide resolved

x-pack/plugins/maps/public/routes/list_page/maps_list_view.tsx Outdated Show resolved Hide resolved

Roll back changes made outside of table list component

5d5e15b

nreese approved these changes Mar 31, 2021

View reviewed changes

kindsun merged commit 5db8027 into elastic:master Apr 1, 2021

kindsun deleted the fix-missing-redirect-on-list-delete branch April 1, 2021 01:15

kindsun mentioned this pull request Apr 1, 2021

[7.x] [Maps] Show empty list when all saved maps in list deleted (#95126) #96009

Merged

kindsun pushed a commit to kindsun/kibana that referenced this pull request Apr 1, 2021

[Maps] Show empty list when all saved maps in list deleted (elastic#9…

c200c8a

…5126) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kindsun mentioned this pull request Apr 1, 2021

[7.12] [Maps] Show empty list when all saved maps in list deleted (#95126) #96010

Merged

kindsun pushed a commit to kindsun/kibana that referenced this pull request Apr 1, 2021

[Maps] Show empty list when all saved maps in list deleted (elastic#9…

27d7736

…5126) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[Maps] Show empty list when all saved maps in list deleted #95126

[Maps] Show empty list when all saved maps in list deleted #95126

Uh oh!

Conversation

kindsun commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Mar 23, 2021

Uh oh!

nreese commented Mar 23, 2021

Uh oh!

kindsun commented Mar 23, 2021

Uh oh!

nreese commented Mar 23, 2021

Uh oh!

kindsun commented Mar 23, 2021

Uh oh!

nreese commented Mar 23, 2021

Uh oh!

kindsun commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kindsun commented Mar 25, 2021

Uh oh!

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

kindsun commented Mar 31, 2021

Uh oh!

Uh oh!

Uh oh!

kindsun commented Mar 31, 2021

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 31, 2021

💚 Build Succeeded

Metrics [docs]

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kindsun commented Mar 23, 2021 •

edited

Loading

kindsun commented Mar 23, 2021 •

edited

Loading