-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ILM] Use global field to set the snapshot repository #94602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| { validator: emptyField(i18nTexts.editPolicy.errors.searchableSnapshotRepoRequired) }, | ||
| ], | ||
| // TODO: update text copy | ||
| helpText: i18n.translate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrodewig can you have a look at this additional copy? Thanks!
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
yuliacech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sebelga, thanks a lot for adding this UI improvement! I tested locally and everything worked. The note about repository setting being the same in all phases is very helpful, but maybe we could make it a bit more prominent? Not sure what a good UX would be to make sure users understand that they change the repository not only in one phase but in all others with searchable snapshot. I don't want to block on it though, so we could address it in a follow up.
|
Thanks for the review @yuliacech ! I agree that we could iterate on the UX to make sure users don't miss that changing the repo in one phase updates the repo in other phases. I didn't want to add yet another Callout so I went with a helptext for now. I trust that, if a user has specified a repository in hot phase and then he goes in the cold phase and he sees the same repo already set-up he might deduce that they are linked. |
...ck/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts
Outdated
Show resolved
Hide resolved
…ections/edit_policy/form/schema.ts Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/ml·ts.ml for user with full ML access with data loaded data frame analytics create job create step for outlier jobStandard OutStack TraceMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There can only be one repository defined for all the ILM "searchable snapshot" actions. This PR makes sure the user does not define different repositories in different phases by updating every repository whenever it is changed in one of the phases.
How to test
/tmpfolder (e.g./tmp/es-snapshots).es/8.0.0/bin/elasticsearch -E path.repo=/tmp/es-snapshots)