[Lens] Stabilize waiting for visualization #93469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Team:Visualizations
Contributor
Author
|
Flaky runner here: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1352/ |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
approved these changes
Mar 4, 2021
Contributor
mbondyra
left a comment
mbondyra
left a comment
There was a problem hiding this comment.
Code looks good and flaky test runner passed so LGTM👌
flash1293
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 4, 2021
Contributor
kibanamachine
added a commit
that referenced
this pull request
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90907
This Pr makes sure the visualization has actually rendered to prevent rare test failures due to bad timing. It's using a similar approach as visualize (adding the render count to a data attribute).
In most cases this will simply introduce an additional wait time of 1s, but it should catch problems where the visualization isn't rendered yet because react is still busy (even if the data fetching is done already).