[Security Solution] Adds getMockTheme function #92840

ecezalp · 2021-02-25T16:34:47Z

Summary

Types the mock themes in tests as EuiTheme.
Replaces the ThemeProvider (from styled-components) with EuiThemeProvider in app.js.
Closes elastic/security-team#866.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

x-pack/plugins/security_solution/public/common/components/and_or_badge/index.test.tsx

x-pack/plugins/security_solution/public/common/mock/get_mock_theme.ts

ecezalp · 2021-03-03T15:35:27Z

@elasticmachine merge upstream

kibanamachine · 2021-03-03T15:35:29Z

merge conflict between base and head

Closes elastic/security-team#866.

kibanamachine · 2021-03-03T18:56:03Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.8MB	7.8MB	-556.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	237.0KB	237.2KB	+238.0B

History

💔 Build #110774 failed 41c972091e7e61c8349b20f27cbc5d5db96e95b3
💚 Build #109457 succeeded db8d98c6dfe2f46381140c893400739ba4f5656e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ecezalp

rylnd

Changes LGTM, thank you. I had a few questions and one nit, but nothing preventing this from being merged.

rylnd · 2021-03-03T23:19:00Z

...ins/security_solution/public/common/components/exceptions/add_exception_modal/index.test.tsx

 } from '../../../../../common/detection_engine/schemas/response/rules_schema.mocks';
 import { useRuleAsync } from '../../../../detections/containers/detection_engine/rules/use_rule_async';
 import { AlertData } from '../types';
+import { getMockTheme } from '../../../lib/kibana/kibana_react.mock';


super nit: I prefer to keep these relative imports roughly organized by distance

Do you have a neat way of doing so by pressing a few keys? Would be super interested in that!!!

rylnd · 2021-03-03T23:19:34Z

...s/security_solution/public/common/components/exceptions/viewer/exception_item/index.test.tsx

    euiColorLightestShade: '#ece',
    euiColorPrimary: '#ece',
-    euiFontWeightSemiBold: 'bold',
+    euiFontWeightSemiBold: 1,


why the change here?

euiFontWeightSemiBold is a number! It's probably 400 or so in the light / dark theme

rylnd · 2021-03-03T23:24:22Z

...plugins/security_solution/public/timelines/components/open_timeline/title_row/index.test.tsx

-  eui: { euiSizeS: '10px', euiLineHeight: '20px', euiBreakpoints: { s: '10px' }, euiSize: '10px' },
-};
+const mockTheme = getMockTheme({
+  eui: { euiSizeS: '10px', euiLineHeight: 10, euiBreakpoints: { s: '10px' }, euiSize: '10px' },


Ditto on the change here; does euiLineHeight simply need a value to prevent the test from blowing up?

* master: (107 commits) [Logs UI] Fix log stream data fetching (elastic#93201) [App Search] Added relevance tuning search preview (elastic#93054) [Canvas] Fix reports embeddables (elastic#93482) [ILM] Added new functional test in ILM for creating a new policy (elastic#92936) Remove direct dependency on statehood package (elastic#93592) [Maps] Track tile loading status (elastic#91585) [Discover][Doc] Improve main documentation (elastic#91854) [Upgrade Assistant] Disable UA and add prompt (elastic#92834) [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609) [Maps] Support GeometryCollections in GeoJson upload (elastic#93507) [XY Charts] fix partial histogram endzones annotations (elastic#93091) [Core] Simplify context typings (elastic#93579) [Alerting] Improving health status check (elastic#93282) [Discover] Restore context documentation (elastic#90784) [core-docs] Edits core-intro section for the new docs system (elastic#93540) add missed codeowners (elastic#89714) fetch node labels via script execution (elastic#93225) [Security Solution] Adds getMockTheme function (elastic#92840) Sort dependencies in package.json correctly (elastic#93590) [Bug] missing timepicker:quickRanges migration (elastic#93409) ...

kibanamachine · 2021-03-08T15:35:54Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 92840 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-03-09T15:45:53Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 92840 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-03-10T15:55:53Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 92840 or prevent reminders by adding the backport:skip label.

Closes elastic/security-team#866. # Conflicts: # x-pack/plugins/security_solution/public/detections/components/rules/query_preview/index.test.tsx

Closes elastic/security-team#866.

Closes elastic/security-team#866. # Conflicts: # x-pack/plugins/security_solution/public/detections/components/rules/query_preview/index.test.tsx

Closes elastic/security-team#866.

ecezalp added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 25, 2021

ecezalp requested a review from rylnd February 25, 2021 16:34

ecezalp self-assigned this Feb 25, 2021

ecezalp requested a review from a team as a code owner February 25, 2021 16:34

rylnd requested changes Mar 1, 2021

View reviewed changes

x-pack/plugins/security_solution/public/common/components/and_or_badge/index.test.tsx Outdated Show resolved Hide resolved

x-pack/plugins/security_solution/public/common/mock/get_mock_theme.ts Outdated Show resolved Hide resolved

ecezalp force-pushed the mock-theme branch from db8d98c to e3139b4 Compare March 3, 2021 15:33

ecezalp requested a review from rylnd March 3, 2021 15:34

ecezalp force-pushed the mock-theme branch from e3139b4 to 41c9720 Compare March 3, 2021 15:37

[Security Solution] Adds getMockTheme function

3b6c5c5

Closes elastic/security-team#866.

ecezalp force-pushed the mock-theme branch from 41c9720 to 3b6c5c5 Compare March 3, 2021 16:53

rylnd approved these changes Mar 3, 2021

View reviewed changes

ecezalp merged commit 3d374e2 into elastic:master Mar 4, 2021

ecezalp deleted the mock-theme branch March 4, 2021 15:31

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 8, 2021

ecezalp added v7.12 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 10, 2021

ecezalp mentioned this pull request Mar 10, 2021

[7.x] [Security Solution] Adds getMockTheme function (#92840) #94326

Merged

ecezalp mentioned this pull request Mar 10, 2021

[7.12] [Security Solution] Adds getMockTheme function (#92840) #94329

Merged

ecezalp added a commit to ecezalp/kibana that referenced this pull request Mar 10, 2021

[Security Solution] Adds getMockTheme function (elastic#92840)

f7b82ce

Closes elastic/security-team#866.

ecezalp added a commit that referenced this pull request Mar 10, 2021

[Security Solution] Adds getMockTheme function (#92840) (#94326)

28e2731

Closes elastic/security-team#866. # Conflicts: # x-pack/plugins/security_solution/public/detections/components/rules/query_preview/index.test.tsx

ecezalp added a commit that referenced this pull request Mar 10, 2021

[Security Solution] Adds getMockTheme function (#92840) (#94329)

3af3ec6

Closes elastic/security-team#866.

elasticmachine unassigned ecezalp Oct 29, 2024

[Security Solution] Adds getMockTheme function #92840

[Security Solution] Adds getMockTheme function #92840

Uh oh!

Conversation

ecezalp commented Feb 25, 2021

Summary

Checklist

Uh oh!

Uh oh!

Uh oh!

ecezalp commented Mar 3, 2021

Uh oh!

kibanamachine commented Mar 3, 2021

Uh oh!

kibanamachine commented Mar 3, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

rylnd left a comment

Choose a reason for hiding this comment

Uh oh!

rylnd Mar 3, 2021

Choose a reason for hiding this comment

Uh oh!

ecezalp Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

rylnd Mar 3, 2021

Choose a reason for hiding this comment

Uh oh!

ecezalp Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

rylnd Mar 3, 2021

Choose a reason for hiding this comment

Uh oh!

ecezalp Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 8, 2021

Uh oh!

kibanamachine commented Mar 9, 2021

Uh oh!

kibanamachine commented Mar 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants