Skip to content

[7.12] [Security Solution][Exceptions] - Fixes exceptions builder UI where invalid values can cause overwrites of other values (#90634) #92750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2021
Merged

[7.12] [Security Solution][Exceptions] - Fixes exceptions builder UI where invalid values can cause overwrites of other values (#90634) #92750

merged 4 commits into from
Feb 25, 2021

Conversation

@yctercero
Copy link
Contributor

@yctercero yctercero commented Feb 25, 2021

Backports the following commits to 7.12:

@yctercero
[Security Solution][Exceptions] - Fixes exceptions builder UI where i…
ee97f4c 
…nvalid values can cause overwrites of other values (elastic#90634)

### Summary

This PR is a follow-up to elastic#89066 - which fixed the same issue occurring with indicator match lists UI. The lack of stable ids for exception item entries resulted in some funky business by where invalid values could overwrite other values when deleting entries in the builder.
@yctercero yctercero added the backport This PR is a backport of another PR label Feb 25, 2021
@yctercero yctercero enabled auto-merge (squash) February 25, 2021 02:36
@yctercero
Copy link
Contributor Author

yctercero commented Feb 25, 2021

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

yctercero commented Feb 25, 2021

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

yctercero commented Feb 25, 2021

#92882 should fix the failure - once merged should go 🟢

@yctercero
Copy link
Contributor Author

yctercero commented Feb 25, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 25, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 130 131 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.7MB 7.7MB +1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lists 143.5KB 145.2KB +1.7KB
securitySolution 244.8KB 245.8KB +948.0B
total +2.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit 93be15a into elastic:7.12 Feb 25, 2021
@yctercero yctercero deleted the backport/7.12/pr-90634 branch October 13, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yctercero @kibanamachine