[ILM][Accessibility] Added A11y test for ILM new policy form. #92570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuff-links
added
Project:Accessibility
test_xpack_functional
Feature:ILM
v8.0.0
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
myasonik
reviewed
Feb 24, 2021
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/dashboard_edit_panel·ts.Dashboard Edit Panel can clone panelStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Feb 25, 2021
…c#92570) * Added A11y test for ILM new policy form. * Separated out the takeSnapshot calls to separate tests.
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Feb 25, 2021
…c#92570) * Added A11y test for ILM new policy form. * Separated out the takeSnapshot calls to separate tests.
cuff-links
pushed a commit
that referenced
this pull request
Feb 25, 2021
#92760) * Added A11y test for ILM new policy form. * Separated out the takeSnapshot calls to separate tests.
cuff-links
pushed a commit
that referenced
this pull request
Feb 25, 2021
#92759) * Added A11y test for ILM new policy form. * Separated out the takeSnapshot calls to separate tests.
jloleysens
reviewed
Feb 25, 2021
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
I know this is already merged; just wanted to say overall this looks good to me. I left a question on the functional test for creating a new policy, not a blocker though!
|
|
||
| // Close panel and save policy | ||
| await testSubjects.click('euiFlyoutCloseButton'); | ||
| await indexLifecycleManagement.saveNewPolicy(); |
Contributor
There was a problem hiding this comment.
Do you think it might be worth waiting for the "list"/"table" view to load? That way we know the policy was successfully created, alternatively we can also check for the toast?
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 25, 2021
* master: (38 commits) Fixes Cypress flake by adding pipe, click, and should (elastic#92762) [Discover] Fix filtering selected sidebar fields (elastic#91828) [ML] Fixes positions of calendar arrow buttons in start datafeed modal (elastic#92625) [dev/build_ts_refs] check that commit in outDirs matches mergeBase (elastic#92513) add dep on `@kbn/config` so it is built first [Expressions] [Lens] Add id and copyMetaFrom arg to mapColumn fn + add configurable onError argument to math fn (elastic#90481) [Lens] Fix Workspace hidden when using Safari (elastic#92616) [Lens] Fixes vertical alignment validation messages (elastic#91878) forbid x-elastic-product-origin header in elasticsearch configuration (elastic#92359) [Security Solution][Detections] Set default indicator path to reduce friction with new filebeat modules (elastic#92081) [ILM][Accessibility] Added A11y test for ILM new policy form. (elastic#92570) [Security Solution][Exceptions] - Fixes exceptions builder UI where invalid values can cause overwrites of other values (elastic#90634) Automatically generated Api documentation (elastic#86232) Increase index pattern select limit to 1000 (elastic#92093) [core.logging] Add RewriteAppender for filtering LogMeta. (elastic#91492) [Security Solution][Detection Rules] Update prebuilt rule threats to match schema (elastic#92281) [Security Solutions][Detection Engine] Fixes bug with not being able to duplicate indicator matches (elastic#92565) [Dashboard] Export appropriate references from byValue panels (elastic#91567) [Upgrade Assistant] Align code between branches (elastic#91862) [Security Solution][Case] Fix alerts push (elastic#91638) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92569
Summary
This PR adds an accessibility test to to ILM to verify the Create New Policy Page. This can be tested by running the accessibility testing suite.