Latency percentile labels and instances table support #91758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add "(avg.)" to dependencies table column label. (This one is always average.) * Add latency aggregation type support to the instances table. * Make the memory usage column a bit wider (it was cut off.)
smith
added
release_note:fix
v8.0.0
v7.12.0
auto-backport
|
Pinging @elastic/apm-ui (Team:apm) |
| @@ -397,12 +405,15 @@ export const serviceInstancesRoute = createRoute({ | |||
| const setup = await setupRequest(context, request); | |||
| const { serviceName } = context.params.path; | |||
| const { transactionType, numBuckets } = context.params.query; | |||
| const latencyAggregationType = (context.params.query | |||
| .latencyAggregationType as unknown) as LatencyAggregationType; | |||
There was a problem hiding this comment.
Why do you need as unknown here?
There was a problem hiding this comment.
Not sure. I get this:
const latencyAggregationType: LatencyAggregationType
Type '"avg" | "p95" | "p99"' is not assignable to type 'LatencyAggregationType'.
Type '"avg"' is not assignable to type 'LatencyAggregationType'.ts(2322)
There was a problem hiding this comment.
I think as LatencyAggregationType is enough, isn't it?
There was a problem hiding this comment.
No that's what I get when I use as LatencyAggregationType.
| @@ -96,7 +96,7 @@ export function ServiceOverviewDependenciesTable({ serviceName }: Props) { | |||
| name: i18n.translate( | |||
| 'xpack.apm.serviceOverview.dependenciesTableColumnLatency', | |||
| { | |||
| defaultMessage: 'Latency', | |||
| defaultMessage: 'Latency (avg.)', | |||
There was a problem hiding this comment.
Can't we also use getLatencyColumnLabel here?
There was a problem hiding this comment.
We could do getLatencyColumnLabel(undefined) but it's always going to be avg because that's the only thing we can get with the dependencies query.
cauemarcondes
approved these changes
Feb 17, 2021
|
retest |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 18, 2021
* Add "(avg.)" to dependencies table column label. (This one is always average.) * Add latency aggregation type support to the instances table. * Make the memory usage column a bit wider (it was cut off.)
kibanamachine
added a commit
that referenced
this pull request
Feb 18, 2021
* Add "(avg.)" to dependencies table column label. (This one is always average.) * Add latency aggregation type support to the instances table. * Make the memory usage column a bit wider (it was cut off.) Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90002. Fixes #89533.