Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Migrate shared role mapping components #91723

Merged
merged 28 commits into from
Feb 22, 2021
Merged

[Enterprise Search] Migrate shared role mapping components #91723

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c6356a2
Initial copy/paste of components
scottybollinger Feb 17, 2021
f62615f
Add types
scottybollinger Feb 17, 2021
c2d6c4f
Add constants
scottybollinger Feb 17, 2021
9596b05
Replace EUI toSentenceCase with lodash startCase
scottybollinger Feb 17, 2021
1dab689
Update paths
scottybollinger Feb 17, 2021
1b19482
Fix test
scottybollinger Feb 17, 2021
891abf3
Fix TypeScript issues
scottybollinger Feb 17, 2021
820a184
Remove ability check for non-federated users
scottybollinger Feb 17, 2021
e1d4fde
Use Kibana React Router helpers
scottybollinger Feb 17, 2021
b7ccfb9
Update comments
scottybollinger Feb 17, 2021
27c3591
Fix failing test
scottybollinger Feb 17, 2021
3e23a4f
Add i18n
scottybollinger Feb 17, 2021
4f755d1
Add tests for smaller components
scottybollinger Feb 17, 2021
9ebde24
Fix fallbacks
scottybollinger Feb 17, 2021
fba159d
Add tests for AttributeSelector
scottybollinger Feb 17, 2021
235b368
Add mocks and testSubj attrs
scottybollinger Feb 18, 2021
6c6b757
Add tests for RoleMappingsTable
scottybollinger Feb 18, 2021
fc839e6
Fix types
scottybollinger Feb 18, 2021
0167313
Refactor for better typing
scottybollinger Feb 18, 2021
6880c20
Remove return type
scottybollinger Feb 19, 2021
96e293e
Rename interface
scottybollinger Feb 19, 2021
852ecc2
Rename more interfaces
scottybollinger Feb 19, 2021
3f27d15
PR feedback
scottybollinger Feb 19, 2021
f09e9fe
Merge branch 'master' into scottybollinger/shared-role-mapping
kibanamachine Feb 19, 2021
6131f2f
Add test for radio checked state
scottybollinger Feb 19, 2021
36f3caa
Add false radio assertion to
scottybollinger Feb 19, 2021
4f9bbd5
Update className
scottybollinger Feb 19, 2021
83a7e45
Merge branch 'master' into scottybollinger/shared-role-mapping
kibanamachine Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...plugins/enterprise_search/public/applications/shared/role_mapping/role_mappings_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,8 @@ export const RoleMappingsTable: React.FC<IRoleMappingsTableProps> = ({
</EuiTableRowCell>
)}
<EuiTableRowCell>
{(!myRole || myRole.ability.invitableRoleTypes().includes(roleType)) && id && (
<Link to={getRoleMappingPath(id)}>Manage</Link>
)}
{(!myRole || myRole.ability.invitableRoleTypes().includes(roleType)) &&
toolTip && <EuiIconTip position="left" content={toolTip.content} />}
{id && <Link to={getRoleMappingPath(id)}>Manage</Link>}
{toolTip && <EuiIconTip position="left" content={toolTip.content} />}
scottybollinger marked this conversation as resolved.
Show resolved Hide resolved
scottybollinger marked this conversation as resolved.
Show resolved Hide resolved
</EuiTableRowCell>
</EuiTableRow>
)
Expand Down