Skip to content

Adds doc titles to security management sections #91013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2021
Merged

Adds doc titles to security management sections #91013

merged 4 commits into from
Feb 22, 2021

Conversation

@legrego
Copy link
Member

@legrego legrego commented Feb 10, 2021 •
edited
Loading

Summary

Adds doc titles to our management sections, and cleans up when necessary.

image

image

image

image

image

Resolves #72672

@legrego legrego added release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.11.1 v7.12.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 10, 2021
@legrego legrego marked this pull request as ready for review February 11, 2021 20:15
@legrego legrego requested a review from a team February 11, 2021 20:15
@legrego legrego requested review from a team as code owners February 11, 2021 20:15
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 11, 2021

Pinging @elastic/kibana-security (Team:Security)

@flash1293
Copy link
Contributor

flash1293 commented Feb 15, 2021

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana app changes LGTM, works as expected

azasypkin
azasypkin approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Is there plan to eventually switch all management views to the "breadcrumb"-based doc title that we use for user management views?

@legrego
Copy link
Member Author

legrego commented Feb 22, 2021 •
edited
Loading

LGTM, thanks! Is there plan to eventually switch all management views to the "breadcrumb"-based doc title that we use for user management views?

Yeah that's not a bad idea. I'll open a followup issue to track this

Edit: opened #92192

@legrego
Copy link
Member Author

legrego commented Feb 22, 2021

@elasticmachine merge upstream

@legrego legrego added v7.11.2 and removed v7.11.1 labels Feb 22, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 22, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 920.1KB 920.2KB +54.0B
savedObjectsManagement 163.8KB 163.8KB +34.0B
savedObjectsTagging 82.9KB 83.0KB +86.0B
total +174.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
savedObjectsTagging 36.1KB 36.1KB +30.0B
security 131.0KB 130.9KB -19.0B
spaces 274.7KB 274.7KB -22.0B
total -11.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego merged commit 12bb59a into elastic:master Feb 22, 2021
@legrego legrego deleted the luke/doc-title branch February 22, 2021 17:00
@kibanamachine kibanamachine mentioned this pull request Feb 22, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2021
@legrego @kibanamachine
Adds doc titles to security management sections (elastic#91013)
69fca8e
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 22, 2021

💔 Backport failed

❌ 7.11: Commit could not be cherrypicked due to conflicts
✅ 7.12 / #92235

Successful backport PRs will be merged automatically after passing CI.

To backport manually, check out the target branch and run:
node scripts/backport --pr 91013

kibanamachine added a commit that referenced this pull request Feb 22, 2021
@kibanamachine @legrego
Adds doc titles to security management sections (#91013) (#92235)
51fa931 
Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
This was referenced Nov 2, 2021
Closed
Merged
@pgayvallet pgayvallet mentioned this pull request Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@azasypkin azasypkin azasypkin approved these changes

@Bamieh Bamieh Bamieh approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.11.2 v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spaces app doesn't set its doc title

7 participants

@legrego @elasticmachine @flash1293 @kibanamachine @pgayvallet @azasypkin @Bamieh