-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ML] Add Create Data Frame Analytics card to Data Visualizer #91011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment on the code. Otherwise LGTM
| }; | ||
| const showCreateJob = | ||
| const mlAvailable = isFullLicense() && checkPermission('canCreateJob') && mlNodesAvailable(); | ||
| const showCreateAnomalyDetectionJob = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you replace the first three checks below with mlAvailable ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated here 97ccf83
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
This PR adds
Create Data Frame Analyticscard to the data visualizer. It also reformats the cards to look consistent.Checklist
Delete any items that are not applicable to this PR.