Skip to content

Uses doc link service in Painless lab #90433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 11, 2021
Merged

Uses doc link service in Painless lab #90433

merged 14 commits into from
Feb 11, 2021
+21 −10

Conversation

@szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Feb 5, 2021

Summary

This PR removes hard-coded links from x-pack/plugins/painless_lab/public/links.ts and replaces them with keywords from the doc link service.

Related issue: #88107

@szabosteve szabosteve added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Painless Lab Dev tool for learning Painless v7.12.0 labels Feb 5, 2021
szabosteve
szabosteve commented Feb 8, 2021
View reviewed changes
@szabosteve
Copy link
Contributor Author

szabosteve commented Feb 9, 2021

@elasticmachine merge upstream

@szabosteve szabosteve marked this pull request as ready for review February 11, 2021 07:41
@szabosteve szabosteve requested review from a team as code owners February 11, 2021 07:41
Bamieh
Bamieh approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@szabosteve
Copy link
Contributor Author

szabosteve commented Feb 11, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 11, 2021

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 477.8KB 478.1KB +378.0B
painlessLab 24.0KB 23.5KB -559.0B
total -181.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this, @szabosteve! Changes LGTM, tested locally and all looks okay 👍

@szabosteve szabosteve merged commit b81967e into elastic:master Feb 11, 2021
@szabosteve szabosteve deleted the dls.painless.lab branch February 11, 2021 16:37
@szabosteve szabosteve mentioned this pull request Feb 11, 2021
Merged
@szabosteve szabosteve mentioned this pull request Feb 11, 2021
Closed
szabosteve added a commit that referenced this pull request Feb 15, 2021
@szabosteve @kibanamachine
Uses doc link service in Painless lab (#90433) (#91155)
957ba15 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bamieh Bamieh Bamieh approved these changes

+1 more reviewer

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Painless Lab Dev tool for learning Painless release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@szabosteve @kibanamachine @Bamieh @yuliacech