Skip to content

[Alerting] Fixing bug with Index Threshold alert when selecting "Of" expression #90174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 8, 2021
Merged

[Alerting] Fixing bug with Index Threshold alert when selecting "Of" expression #90174

merged 6 commits into from
Feb 8, 2021

Conversation

@ymao1
Copy link
Contributor

@ymao1 ymao1 commented Feb 3, 2021 •
edited
Loading

Summary

Caused by a bad merge between these two PRs: #88528 and #88540

To recreate the bug:

  1. Create an Index Threshold alert
  2. Select an index and timestamp field
  3. Change "When" expression to avg()
  4. Open "Of" expression and notice no fields from the selected index are available.

This PR should fix so index fields are populated in the Of expression. I also updated the functional test to follow this UI workflow

Checklist

Delete any items that are not applicable to this PR.

@ymao1 ymao1 self-assigned this Feb 3, 2021
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.12.0 v8.0.0 labels Feb 3, 2021
@ymao1 ymao1 marked this pull request as ready for review February 3, 2021 18:19
@ymao1 ymao1 requested a review from a team as a code owner February 3, 2021 18:19
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 3, 2021

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko
YulNaumenko approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Feb 4, 2021

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Feb 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 8, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackAlerts 681.5KB 681.5KB -5.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 145.9KB 145.9KB +70.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gmmorris gmmorris self-requested a review February 8, 2021 15:23
gmmorris
gmmorris approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected :)

@ymao1 ymao1 merged commit 4b29e35 into elastic:master Feb 8, 2021
ymao1 added a commit to ymao1/kibana that referenced this pull request Feb 8, 2021
@ymao1 @kibanamachine
[Alerting] Fixing bug with Index Threshold alert when selecting "Of" …
84c2139 
…expression (elastic#90174)

* Fixing bug

* Updating functional test

* Fixing functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@ymao1 ymao1 mentioned this pull request Feb 8, 2021
Merged
ymao1 added a commit that referenced this pull request Feb 8, 2021
@ymao1 @kibanamachine
[Alerting] Fixing bug with Index Threshold alert when selecting "Of" …
392ba21 
…expression (#90174) (#90643)

* Fixing bug

* Updating functional test

* Fixing functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@ymao1 ymao1 deleted the alerting/index-threshold-bug branch March 25, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

+1 more reviewer

@gmmorris gmmorris gmmorris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ymao1 ymao1

Labels

Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ymao1 @elasticmachine @kibanamachine @gmmorris @YulNaumenko