[7.x] Round start and end values (#89030) #90035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the start and end times, use the d3 time scale `ticks` function to round the start and end times.
Example from a query:
Before:
```json
{
"range": {
"@timestamp": {
"gte": 1611262874814,
"lte": 1611263774814,
"format": "epoch_millis"
}
}
},
```
After:
```json
{
"range": {
"@timestamp": {
"gte": 1611263040000,
"lte": 1611263880000,
"format": "epoch_millis"
}
}
},
```
The `ticks` function makes it so the amount of rounding is proportional to the size of the time range, so shorter time ranges will be rounded less.
Also fix a bug where invalid ranges in the query string were not handled correctly.
Fixes elastic#84530.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: