Skip to content

Conversation

@ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jan 29, 2021

Summary

When backporting the search alert PR, there were a few small issues that showed up in the 7.x branch that did not appear on master. I believe these are attributed to the two branches using different versions of @elastic/elasticsearch. I thought it best to add these fixes to master as well.

@ymao1 ymao1 changed the title Some fixes from backport [Alerting] Search alert fixes from backport Jan 29, 2021
@ymao1 ymao1 self-assigned this Jan 29, 2021
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.0.0 labels Jan 29, 2021
@ymao1 ymao1 marked this pull request as ready for review January 29, 2021 18:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Feb 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ymao1 ymao1 merged commit 57453f1 into elastic:master Feb 1, 2021
@ymao1 ymao1 added the backport:skip This PR does not require backporting label Feb 1, 2021
@ymao1 ymao1 deleted the alerting/search-alert-fixes branch March 25, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants