[Upgrade assistant] Clean up i18n #89661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
chore
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
yuliacech
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Hi @alisonelizabeth , thanks for updating UA to use the correct i18n function 👍
code LGTM, didn't test locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
injectI18n()in favor ofi18n.translate()in Upgrade Assistant per i18n guidelines.Most of the text affects the overview tab in Upgrade Assistant. There are also some table headers updated that are rendered under the "Indices" tab. If you'd like to test this, you'll need to hack
x-pack/plugins/upgrade_assistant/server/lib/es_migration_apis.tsas described in #89207.