Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error thrown when Kibana is sent a SIGHUP to reload logging config #89218

Merged
merged 5 commits into from
Jan 29, 2021
Merged

Fix error thrown when Kibana is sent a SIGHUP to reload logging config #89218

merged 5 commits into from
Jan 29, 2021

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Jan 25, 2021 •
edited
Loading

Without these changes, the following error is logged when Kibana is sent a SIGHUP:

  log   [12:03:59.220] [error][legacy-service] TypeError: Cannot read property 'reconfigure' of undefined
    at reconfigureLogging (/Users/kobelb/Projects/elastic/kibana/packages/kbn-legacy-logging/target/setup_logging.js:30:37)
    at KbnServer.applyLoggingConfiguration (/Users/kobelb/Projects/elastic/kibana/src/legacy/server/kbn_server.js:156:5)
    at TapSubscriber._tapNext (/Users/kobelb/Projects/elastic/kibana/src/core/server/legacy/legacy_service.ts:97:26)
    at TapSubscriber._next (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/operators/tap.ts:120:21)
    at TapSubscriber.Subscriber.next (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/Subscriber.ts:99:12)
    at CombineLatestSubscriber.notifyNext (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/observable/combineLatest.ts:312:26)
    at InnerSubscriber._next (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/InnerSubscriber.ts:17:17)
    at InnerSubscriber.Subscriber.next (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/Subscriber.ts:99:12)
    at ReplaySubject.Subject.next (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/Subject.ts:70:17)
    at ReplaySubject.nextInfiniteTimeWindow (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/ReplaySubject.ts:47:15)
    at Object.next (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/operators/shareReplay.ts:100:31)
    at SafeSubscriber.__tryOrUnsub (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/Subscriber.ts:265:10)
    at SafeSubscriber.next (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/Subscriber.ts:207:14)
    at Subscriber._next (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/Subscriber.ts:139:22)
    at Subscriber.next (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/Subscriber.ts:99:12)
    at MapSubscriber._next (/Users/kobelb/Projects/elastic/kibana/node_modules/rxjs/src/internal/operators/map.ts:89:22)

I'm not seeing this issue in the 7.11 BC. I'm guessing hapijs/hapi#4011 introduced it in version 19.0.0 and when we upgraded @hapi/hapi we didn't catch this. As a result, we don't need it in the release notes.

@kobelb kobelb added v8.0.0 v7.12.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 26, 2021
@kobelb kobelb marked this pull request as ready for review January 27, 2021 15:57
@kobelb kobelb requested a review from a team as a code owner January 27, 2021 15:57
@kobelb
Copy link
Contributor Author

kobelb commented Jan 27, 2021

@elasticmachine merge upstream

@kobelb kobelb requested a review from pgayvallet January 27, 2021 15:58
@pgayvallet
Copy link
Contributor

retest

Bamieh
Bamieh approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobelb
Copy link
Contributor Author

kobelb commented Jan 29, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kobelb kobelb merged commit a6fe0a2 into elastic:master Jan 29, 2021
@kobelb kobelb deleted the fix/logging-reload branch January 29, 2021 18:36
@kobelb kobelb mentioned this pull request Jan 29, 2021
Merged
kobelb added a commit to kobelb/kibana that referenced this pull request Jan 29, 2021
@kobelb @kibanamachine
Fix error thrown when Kibana is sent a SIGHUP to reload logging config (
4de24d7 
elastic#89218)

* Fix error thrown when Kibana is sent a SIGHUP to reload logging config

* Adding a simple unit test to catch a future regression

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kobelb added a commit that referenced this pull request Jan 29, 2021
@kobelb @kibanamachine
Fix error thrown when Kibana is sent a SIGHUP to reload logging config (
11d4431 
#89218) (#89771)

* Fix error thrown when Kibana is sent a SIGHUP to reload logging config

* Adding a simple unit test to catch a future regression

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@Bamieh Bamieh Bamieh approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobelb @pgayvallet @kibanamachine @Bamieh