Skip to content

Conversation

@neptunian
Copy link
Contributor

@neptunian neptunian commented Jan 21, 2021

Summary

Resolves #82313

  • Remove the middle tick from the stepped gradient legend
  • Use value instead of max from metric to calculate the max bound

Before:
Screen Shot 2021-01-21 at 1 54 21 PM

After:
Screen Shot 2021-01-28 at 10 37 45 AM

Checklist

@neptunian neptunian added bug Fixes for quality problems that affect the customer experience release_note:fix Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.12.0 labels Jan 21, 2021
@neptunian neptunian self-assigned this Jan 21, 2021
@neptunian neptunian requested a review from a team as a code owner January 21, 2021 19:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@neptunian neptunian force-pushed the 82313-fix-legend-tick-values branch from 58d47d8 to 3797b20 Compare January 28, 2021 15:35
@neptunian neptunian changed the title [Metrics UI] fix mid number in legend sometimes larger than min number [Metrics UI] remove middle number in legend and adjust calculate of max number Jan 28, 2021
@neptunian neptunian changed the title [Metrics UI] remove middle number in legend and adjust calculate of max number [Metrics UI] remove middle number in legend and adjust calculation of max number Jan 28, 2021
@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.2MB 2.2MB -268.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neptunian neptunian merged commit 16500d8 into elastic:master Feb 1, 2021
neptunian added a commit to neptunian/kibana that referenced this pull request Feb 1, 2021
… max number (elastic#89020)

* get midpoint of max and min instead of half of max number

* remove middle tick from stepped gradient legend

* use value instead of max values to calculate bounds

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
neptunian added a commit to neptunian/kibana that referenced this pull request Feb 1, 2021
… max number (elastic#89020)

* get midpoint of max and min instead of half of max number

* remove middle tick from stepped gradient legend

* use value instead of max values to calculate bounds

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
neptunian added a commit that referenced this pull request Feb 1, 2021
… max number (#89020) (#89894)

* get midpoint of max and min instead of half of max number

* remove middle tick from stepped gradient legend

* use value instead of max values to calculate bounds

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
neptunian added a commit that referenced this pull request Feb 1, 2021
… max number (#89020) (#89893)

* get midpoint of max and min instead of half of max number

* remove middle tick from stepped gradient legend

* use value instead of max values to calculate bounds

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Metrics App] Waffle map scale is sometimes in the wrong order

5 participants