Skip to content

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Jan 20, 2021

Summary

Closes #36544
This PR enables the color picker on the legends of the timeseries tab. I used the same picker as the one used on the visualizations.

Screenshot 2021-02-04 at 11 42 15 AM

The user can change the default color of a series. You can see how it works on the following video

TSVB-legend-color-picker

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula changed the title Allow users to change the colors series for terms split [TSVB] Allow users to change the colors series for terms split Jan 21, 2021
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula changed the title [TSVB] Allow users to change the colors series for terms split [TSVB] Allow users to change the colors series from the legend Feb 4, 2021
@stratoula
Copy link
Contributor Author

This is a draft PR but I would love your feedback on the changes @alexfrancoeur @markov00

@stratoula stratoula changed the title [TSVB] Allow users to change the colors series from the legend [TSVB] Allow users to change the series color from the legend Feb 4, 2021
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula changed the title [TSVB] Allow users to change the series color from the legend [TSVB] Allows users to change the series color from the legend Feb 15, 2021
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

I am closing it, we have to define our coloring strategy in general. We will return to this, after that.

@stratoula stratoula closed this Mar 3, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 471 473 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.7MB 1.7MB +11.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTimeseries 126.8KB 129.9KB +3.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Time Series Visual Builder] Color configuration for metrics that have been grouped

3 participants