[Alerting] Fixing broken Alerts view when no Global All Kibana privilege #88727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
changed the title
ymao1
commented
Jan 19, 2021
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/home_page.ts
Show resolved
Hide resolved
ymao1
added
Feature:Alerting
release_note:skip
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
rashmivkulkarni
approved these changes
Jan 19, 2021
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/home_page.ts
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Jan 19, 2021
…ege (elastic#88727) * Making kibanaFeatures an optional parameter and catching error on plugin start * Gracefully handle 404 errors when no access to features endpoint * Adding functional test
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Jan 19, 2021
…ege (elastic#88727) * Making kibanaFeatures an optional parameter and catching error on plugin start * Gracefully handle 404 errors when no access to features endpoint * Adding functional test # Conflicts: # x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/home_page.ts
kobelb
pushed a commit
that referenced
this pull request
Jan 20, 2021
… privilege (#88727) (#88781) * [Alerting] Fixing broken Alerts view when no Global All Kibana privilege (#88727) * Making kibanaFeatures an optional parameter and catching error on plugin start * Gracefully handle 404 errors when no access to features endpoint * Adding functional test # Conflicts: # x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/home_page.ts * Fixing linting Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #88624
Summary
Wrapping the
getFeatures()API call in a try/catch block to catch 404 errors that arise when a user doesn't have the permissions to access that API.Checklist
Delete any items that are not applicable to this PR.