[Search Sessions] Make search session indicator UI opt-in #88699

Dosant · 2021-01-19T16:38:49Z

Summary

Previously the idea was that the search session indicator won't appear if an app doesn't use the search session. But recently Lens started using them without completing full integration #86297. If to enable xpack.data_enhanced.search.sessions.enabled in master, then Lens show search session indicator, but sending session to background doesn't properly work.

This pr changes the underlying logic of session service to show session indicator only app explicitly asked for that.

Also, I noticed, that we checked for per-app capabilities inside the data plugin component. I moved it outside and so now apps can configure search session indicator UI. In this case by setting it to disabled state.

What to test

The only user-facing difference comparing to master is that the search session indicator shouldn't appear in the Lens app.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

…t-in-to-session-ui # Conflicts: # src/plugins/data/public/public.api.md

elasticmachine · 2021-01-20T14:08:45Z

Pinging @elastic/kibana-app-services (Team:AppServices)

Dosant · 2021-01-21T10:44:34Z

@elasticmachine merge upstream

…t-in-to-session-ui

…ibana into dev/search/opt-in-to-session-ui

lizozom

Overall looks great.
Maybe we could add this to the sessions_in_space tests?
Should be simple enough to create a user that doesn't have this permission, and see that the component is properly disabled.

src/plugins/data/public/search/session/i18n.ts

src/plugins/dashboard/public/application/hooks/use_dashboard_state_manager.ts

src/plugins/data/public/search/session/session_service.ts

src/plugins/data/public/search/session/session_service.test.ts

Dosant · 2021-01-21T17:12:09Z

@elasticmachine merge upstream

lizozom · 2021-01-25T08:36:04Z

@elasticmachine merge upstream

…ot shown

Dosant · 2021-01-25T10:25:12Z

@lizozom,

Maybe we could add this to the sessions_in_space tests?

I added these tests as you suggested.
I also added a lens test checking that there is no search session indicator in the UI.

flash1293 · 2021-01-25T10:31:30Z

Requires a deeper look into Discover, but indicator isn't showing up anymore in Lens, which LGTM

lizozom

Just tested with and without permissions and seems good!
LGTM

kertal · 2021-01-26T06:16:52Z

@elasticmachine merge upstream

kertal

Code LGTM, search sessions still work in Discover, tested locally in Chrome 👍

ThomThomson

Code only review - Dashboard changes LGTM.

Dosant · 2021-01-27T09:06:03Z

@elasticmachine merge upstream

kibanamachine · 2021-01-27T10:47:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9b43a6e

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`data`	614	615	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	158.4KB	158.7KB	+277.0B
`discover`	420.2KB	420.3KB	+143.0B
total			+420.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dashboard`	295.2KB	295.5KB	+325.0B
`data`	798.3KB	799.0KB	+741.0B
`dataEnhanced`	36.4KB	35.9KB	-434.0B
total			+632.0B

History

💚 Build #100998 succeeded 377b76f
💚 Build #100646 succeeded a0235f8
💚 Build #100597 succeeded 6385ef5
💚 Build #100393 succeeded 75eebca
💔 Build #100367 failed d01cade

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…er-app capabilities (elastic#88699)

…er-app capabilities (#88699) (#89407)

…y-tests * 'master' of github.com:elastic/kibana: (276 commits) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) skip flaky suite (elastic#89379) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/test/accessibility/config.ts

…ana into task-manager/shift-on-trend * 'task-manager/shift-on-trend' of github.com:gmmorris/kibana: (74 commits) [Metrics UI] Fix Host Overview boxes in Host Detail page (elastic#89299) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) ...

Dosant added 5 commits January 19, 2021 17:31

make apps to opt-in to search session inducator UI

c93ef6a

Merge branch 'master' of github.com:elastic/kibana into dev/search/op…

47d2dec

…t-in-to-session-ui # Conflicts: # src/plugins/data/public/public.api.md

post license merge

75b4b39

doc text message

c8e2a8a

better comments

4d041db

Dosant marked this pull request as ready for review January 20, 2021 14:08

Dosant requested a review from a team January 20, 2021 14:08

Dosant requested review from a team as code owners January 20, 2021 14:08

Dosant added Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:AppServices v7.12.0 v8.0.0 labels Jan 20, 2021

kibanamachine and others added 4 commits January 21, 2021 05:44

Merge branch 'master' into dev/search/opt-in-to-session-ui

3f3f71b

Merge branch 'master' of github.com:elastic/kibana into dev/search/op…

a1163ef

…t-in-to-session-ui

docs update

5b9ef91

Merge branch 'dev/search/opt-in-to-session-ui' of github.com:Dosant/k…

6cd4177

…ibana into dev/search/opt-in-to-session-ui

lizozom reviewed Jan 21, 2021

View reviewed changes

src/plugins/data/public/search/session/i18n.ts Outdated Show resolved Hide resolved

src/plugins/dashboard/public/application/hooks/use_dashboard_state_manager.ts Show resolved Hide resolved

src/plugins/data/public/search/session/session_service.ts Outdated Show resolved Hide resolved

lizozom reviewed Jan 21, 2021

View reviewed changes

src/plugins/data/public/search/session/session_service.test.ts Outdated Show resolved Hide resolved

review

d01cade

Merge branch 'master' into dev/search/opt-in-to-session-ui

75eebca

kibanamachine and others added 3 commits January 25, 2021 03:36

Merge branch 'master' into dev/search/opt-in-to-session-ui

6385ef5

add lens functional test checking that search sessions indicator is n…

711c0dd

…ot shown

add funcitonal test checking storing search sessions is disabled

a0235f8

Dosant requested a review from lizozom January 25, 2021 10:25

Dosant requested review from ThomThomson and kertal January 25, 2021 10:32

lizozom approved these changes Jan 25, 2021

View reviewed changes

Dosant added Feature:Dashboard Dashboard related features Feature:Discover Discover Application labels Jan 25, 2021

Merge branch 'master' into dev/search/opt-in-to-session-ui

377b76f

kertal approved these changes Jan 26, 2021

View reviewed changes

ThomThomson approved these changes Jan 26, 2021

View reviewed changes

Merge branch 'master' into dev/search/opt-in-to-session-ui

9b43a6e

Dosant merged commit b8947e3 into elastic:master Jan 27, 2021

Dosant added a commit to Dosant/kibana that referenced this pull request Jan 27, 2021

[Search Sessions] Make search session indicator UI opt-in, refactor p…

0cdc25b

…er-app capabilities (elastic#88699)

Dosant mentioned this pull request Jan 27, 2021

[7.x] [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (#88699) #89407

Merged

Dosant added a commit that referenced this pull request Jan 27, 2021

[Search Sessions] Make search session indicator UI opt-in, refactor p…

198ca1b

…er-app capabilities (#88699) (#89407)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Search Sessions] Make search session indicator UI opt-in #88699

[Search Sessions] Make search session indicator UI opt-in #88699

Dosant commented Jan 19, 2021 •

edited

Loading

elasticmachine commented Jan 20, 2021

Dosant commented Jan 21, 2021

lizozom left a comment

Dosant commented Jan 21, 2021

lizozom commented Jan 25, 2021

Dosant commented Jan 25, 2021

flash1293 commented Jan 25, 2021

lizozom left a comment

kertal commented Jan 26, 2021

kertal left a comment

ThomThomson left a comment

Dosant commented Jan 27, 2021

kibanamachine commented Jan 27, 2021

[Search Sessions] Make search session indicator UI opt-in #88699

[Search Sessions] Make search session indicator UI opt-in #88699

Conversation

Dosant commented Jan 19, 2021 • edited Loading

Summary

What to test

Checklist

For maintainers

elasticmachine commented Jan 20, 2021

Dosant commented Jan 21, 2021

lizozom left a comment

Choose a reason for hiding this comment

Dosant commented Jan 21, 2021

lizozom commented Jan 25, 2021

Dosant commented Jan 25, 2021

flash1293 commented Jan 25, 2021

lizozom left a comment

Choose a reason for hiding this comment

kertal commented Jan 26, 2021

kertal left a comment

Choose a reason for hiding this comment

ThomThomson left a comment

Choose a reason for hiding this comment

Dosant commented Jan 27, 2021

kibanamachine commented Jan 27, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Dosant commented Jan 19, 2021 •

edited

Loading