[timelion] Remove saved sheets link #8778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will remove the link from everywhere in Kibana rather than only in Timelion |
|
I think Graph is successfully removing the link, so you might want to look at how it's being done there |
|
I did not look at this close enough. Fixing. |
Currently saved timelion sheets are not showing up in the saved objects page, so the link errors and loads a blank page
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Oct 20, 2016
--------- **Commit 1:** [timelion] Remove saved sheets link Currently saved timelion sheets are not showing up in the saved objects page, so the link errors and loads a blank page * Original sha: 19e5af9 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-10-20T14:29:15Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 20, 2016
--------- **Commit 1:** [timelion] Remove saved sheets link Currently saved timelion sheets are not showing up in the saved objects page, so the link errors and loads a blank page * Original sha: 19e5af9 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-10-20T14:29:15Z
This was referenced Oct 20, 2016
epixa
added a commit
that referenced
this pull request
Oct 20, 2016
[backport] PR #8778 to 5.0 - [timelion] Remove saved sheets link
epixa
added a commit
that referenced
this pull request
Oct 20, 2016
[backport] PR #8778 to 5.x - [timelion] Remove saved sheets link
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** [timelion] Remove saved sheets link Currently saved timelion sheets are not showing up in the saved objects page, so the link errors and loads a blank page * Original sha: 8e92fa8afc959d0dc3438243d4bfd8d4027dc052 [formerly 19e5af9] * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-10-20T14:29:15Z Former-commit-id: 8e5a9dd
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8778 to 5.x - [timelion] Remove saved sheets link Former-commit-id: 2ca0c19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently saved timelion sheets are not showing up in the saved objects page, so the link errors and loads a blank page. This removes the link.
Closes #8771