Skip to content

Conversation

@qn895
Copy link
Member

@qn895 qn895 commented Jan 6, 2021

Summary

This PR is a follow up of #85726 which updates the file based data visualizer to follow the new design. It also updates the functional tests for file based data visualizer.

Before
Data Visualizer - Machine Learning - Elastic (8)

After
Data Visualizer - Machine Learning - Elastic (12)

Todo/Follow up PRs

  • Better support for geo fields (will do in a follow up PR)

Checklist

Delete any items that are not applicable to this PR.

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of my test files (ts_head.log) crashes the ML app on data visualizer load (blank page, have to switch to a different Kibana app and come back to ML again). The console shows the following error:
image

@peteharverson peteharverson requested review from jgowdyelastic and removed request for walterra January 7, 2021 15:15
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is quite close! Just a few comments:

  1. It looks like we have different gutter sizes set on the flex group for the expanded row depending on the field type.
    Keyword:
    image

Number:
image

  1. It might be nice to force the stats table to have a max-width and then the subsequent columns will start at the same point

image

With a width set (instead of a percent value for the columns).
image

@qn895
Copy link
Member Author

qn895 commented Jan 15, 2021

Thanks @mdefazio I have updated the gutter size to all match in the latest changes as well as having a fixed pixel number for the Document stats column
Data Visualizer - Machine Learning - Elastic (13)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edits and LGTM

import type { PartialTheme } from '@elastic/charts';
import { useUiSettings } from '../../../contexts/kibana';
export const useDataVizChartTheme = (): PartialTheme => {
const isDarkTheme = useUiSettings().get('theme:darkMode');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be using useUiSettings in a hook like this, shouldn't it be watching for changes in the settings?
Like this function:

Otherwise it doesn't need to be in a hook.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. This is now updated here e09dc6f

@qn895 qn895 requested a review from mdefazio January 19, 2021 15:49
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this all looks good.

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1694 1712 +18

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 7.1MB 7.0MB -23.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895 qn895 merged commit 27c77ad into elastic:master Jan 20, 2021
qn895 added a commit to qn895/kibana that referenced this pull request Jan 20, 2021
@lcawl lcawl added the release_note:feature Makes this part of the condensed release notes label Feb 5, 2021
@qn895 qn895 deleted the ml-file-based-data-viz branch April 27, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:enhancement release_note:feature Makes this part of the condensed release notes v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants