-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ML] Redesign file-based Data Visualizer #87598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…agrid, update mappings
x-pack/test/functional/apps/ml/data_visualizer/files_to_import/artificial_server_log
Show resolved
Hide resolved
pheyos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of my test files (ts_head.log) crashes the ML app on data visualizer load (blank page, have to switch to a different Kibana app and come back to ML again). The console shows the following error:

mdefazio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is quite close! Just a few comments:
- It looks like we have different gutter sizes set on the flex group for the expanded row depending on the field type.
Keyword:

- It might be nice to force the stats table to have a max-width and then the subsequent columns will start at the same point
With a width set (instead of a percent value for the columns).

|
Thanks @mdefazio I have updated the gutter size to all match in the latest changes as well as having a fixed pixel number for the |
peteharverson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest edits and LGTM
| import type { PartialTheme } from '@elastic/charts'; | ||
| import { useUiSettings } from '../../../contexts/kibana'; | ||
| export const useDataVizChartTheme = (): PartialTheme => { | ||
| const isDarkTheme = useUiSettings().get('theme:darkMode'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be using useUiSettings in a hook like this, shouldn't it be watching for changes in the settings?
Like this function:
kibana/x-pack/plugins/ml/public/application/components/color_range_legend/use_color_range.ts
Line 192 in f7fdda5
| export function useCurrentEuiTheme() { |
Otherwise it doesn't need to be in a hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. This is now updated here e09dc6f
jgowdyelastic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mdefazio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and this all looks good.
darnautov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |



Summary
This PR is a follow up of #85726 which updates the file based data visualizer to follow the new design. It also updates the functional tests for file based data visualizer.
Before

After

Todo/Follow up PRs
Checklist
Delete any items that are not applicable to this PR.