[Alerting] revert the revert of Enforces typing of Alert's ActionGroups
#87382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
Team:APM - DEPRECATED
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
gmmorris
added
Feature:Alerting
release_note:skip
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
kindsun
approved these changes
Jan 5, 2021
Contributor
kindsun
left a comment
kindsun
left a comment
There was a problem hiding this comment.
Changes to geo alerts lgtm! Sorry for the typing trouble, looks like maybe our PRs crossed paths 😬 Thanks for the type updates! 🙇
- code review
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
Page load bundle
To update your PR or re-run it, just comment with: |
Contributor
Author
All good! 👍 |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 6, 2021
…ups` (elastic#87382) The elastic#86761 PR was reverted due to a small typing issue. This PR reverts that revert and adds a commit to address the issue: elastic@9e4ab20.
gmmorris
added a commit
that referenced
this pull request
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The #86761 PR was reverted due to a small typing issue.
This PR reverts that revert and adds a commit to address the issue: 9e4ab20.
As this is reapplying a revert of an already. reviewed PR due to typing issues I'm flexing on the normal review process in order not to waste time of the 6 teams who already reviewed the original PR.
I've pinged @mikecote & @aaronjcaldwell to review for Alerting (who own this feature) & Maps (where the typing issue happened) so they can review the revert and the Maps fix.
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosAny UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)This was checked for cross-browser compatibilityFor maintainers