Skip to content

[7.x] [Alerting] Enforces typing of Alert's ActionGroups (#86761) #87373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[7.x] [Alerting] Enforces typing of Alert's ActionGroups (#86761) #87373

wants to merge 1 commit into from

Conversation

@gmmorris
Copy link
Contributor

@gmmorris gmmorris commented Jan 5, 2021

Backports the following commits to 7.x:

@gmmorris
[Alerting] Enforces typing of Alert's ActionGroups (elastic#86761)
f0df49f 
This PR tightens the typing on the Alerting framework's `AlertType` and its deeper typing around `AlertServices ` and `AlertExecutorOptions`.

This ensures the following:

1. It's now impossible<sup>✴</sup> to schedule actions on any ActionGroup other than the groups specified on the AlertType (including the Recovery group)
2. It's now impossible<sup>✴</sup> to schedule actions with incorrect `InstanceState` or `InstanceContext`

✴ Unless they bypass the Typescript typing, which is an explicit choice to bypass type safety
@gmmorris gmmorris added the backport This PR is a backport of another PR label Jan 5, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 5, 2021 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

Security OSS Functional Tests.test/security_functional/insecure_cluster_warning·ts.Security OSS Insecure Cluster Warning "before all" hook in "Insecure Cluster Warning"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: Security OSS
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: Insecure Cluster Warning
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> "before all" hook
[00:00:00]               │ debg navigating to home url: http://localhost:61141/app/home
[00:00:00]               │ debg navigate to: http://localhost:61141/app/home
[00:00:00]               │ debg browser[INFO] http://localhost:61141/app/home?_t=1609874609305 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:00]               │
[00:00:00]               │ debg browser[INFO] http://localhost:61141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:00]               │ debg ... sleep(700) start
[00:00:00]               │ debg ... sleep(700) end
[00:00:00]               │ debg returned from get, calling refresh
[00:00:01]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:195249 Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE].
[00:00:01]               │          at ui_actions_service_UiActionsService.attachAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:58756)
[00:00:01]               │          at ui_actions_service_UiActionsService.addTriggerAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:59571)
[00:00:01]               │          at plugin_DataPublicPlugin.setup (http://localhost:61141/37681/bundles/plugin/data/data.plugin.js:8:233403)
[00:00:01]               │          at _callee$ (http://localhost:61141/37681/bundles/core/core.entry.js:13:252168)
[00:00:01]               │          at l (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968491)
[00:00:01]               │          at Generator._invoke (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968244)
[00:00:01]               │          at Generator.forEach.e.<computed> [as next] (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968848)
[00:00:01]               │          at plugin_asyncGeneratorStep (http://localhost:61141/37681/bundles/core/core.entry.js:13:250272)
[00:00:01]               │          at _next (http://localhost:61141/37681/bundles/core/core.entry.js:13:250589)
[00:00:01]               │ debg browser[INFO] http://localhost:61141/app/home?_t=1609874609305 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:01]               │
[00:00:01]               │ debg browser[INFO] http://localhost:61141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:01]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:195249 Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE].
[00:00:01]               │          at ui_actions_service_UiActionsService.attachAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:58756)
[00:00:01]               │          at ui_actions_service_UiActionsService.addTriggerAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:59571)
[00:00:01]               │          at plugin_DataPublicPlugin.setup (http://localhost:61141/37681/bundles/plugin/data/data.plugin.js:8:233403)
[00:00:01]               │          at _callee$ (http://localhost:61141/37681/bundles/core/core.entry.js:13:252168)
[00:00:01]               │          at l (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968491)
[00:00:01]               │          at Generator._invoke (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968244)
[00:00:01]               │          at Generator.forEach.e.<computed> [as next] (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968848)
[00:00:01]               │          at plugin_asyncGeneratorStep (http://localhost:61141/37681/bundles/core/core.entry.js:13:250272)
[00:00:01]               │          at _next (http://localhost:61141/37681/bundles/core/core.entry.js:13:250589)
[00:00:01]               │ debg browser[INFO] http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 390:89301 "Version 9 of Highlight.js has reached EOL and is no longer supported.
[00:00:01]               │      Please upgrade or ask whatever dependency you are using to upgrade.
[00:00:01]               │      https://github.com/highlightjs/highlight.js/issues/2877"
[00:00:01]               │ debg browser[INFO] http://localhost:61141/37681/bundles/core/core.entry.js 12:196196 "Detected an unhandled Promise rejection.
[00:00:01]               │      Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE]."
[00:00:01]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:357477 Uncaught Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exis…ttaching action [actionId = ACTION_SELECT_RANGE].
[00:00:01]               │ debg currentUrl = http://localhost:61141/app/home
[00:00:01]               │          appUrl = http://localhost:61141/app/home
[00:00:01]               │ debg TestSubjects.find(kibanaChrome)
[00:00:01]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:01:02]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
[00:01:02]               │      Wait timed out after 60186ms
[00:01:02]               │ debg navigate to: http://localhost:61141/app/home
[00:01:02]               │ debg browser[INFO] http://localhost:61141/app/home?_t=1609874671850 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:02]               │
[00:01:02]               │ debg browser[INFO] http://localhost:61141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:02]               │ debg ... sleep(700) start
[00:01:03]               │ debg ... sleep(700) end
[00:01:03]               │ debg returned from get, calling refresh
[00:01:03]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:195249 Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE].
[00:01:03]               │          at ui_actions_service_UiActionsService.attachAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:58756)
[00:01:03]               │          at ui_actions_service_UiActionsService.addTriggerAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:59571)
[00:01:03]               │          at plugin_DataPublicPlugin.setup (http://localhost:61141/37681/bundles/plugin/data/data.plugin.js:8:233403)
[00:01:03]               │          at _callee$ (http://localhost:61141/37681/bundles/core/core.entry.js:13:252168)
[00:01:03]               │          at l (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968491)
[00:01:03]               │          at Generator._invoke (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968244)
[00:01:03]               │          at Generator.forEach.e.<computed> [as next] (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968848)
[00:01:03]               │          at plugin_asyncGeneratorStep (http://localhost:61141/37681/bundles/core/core.entry.js:13:250272)
[00:01:03]               │          at _next (http://localhost:61141/37681/bundles/core/core.entry.js:13:250589)
[00:01:03]               │ debg browser[INFO] http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 390:89301 "Version 9 of Highlight.js has reached EOL and is no longer supported.
[00:01:03]               │      Please upgrade or ask whatever dependency you are using to upgrade.
[00:01:03]               │      https://github.com/highlightjs/highlight.js/issues/2877"
[00:01:03]               │ debg browser[INFO] http://localhost:61141/37681/bundles/core/core.entry.js 12:196196 "Detected an unhandled Promise rejection.
[00:01:03]               │      Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE]."
[00:01:03]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:357477 Uncaught Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exis…ttaching action [actionId = ACTION_SELECT_RANGE].
[00:01:03]               │ debg browser[INFO] http://localhost:61141/app/home?_t=1609874671850 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:03]               │
[00:01:03]               │ debg browser[INFO] http://localhost:61141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:03]               │ debg currentUrl = http://localhost:61141/app/home
[00:01:03]               │          appUrl = http://localhost:61141/app/home
[00:01:03]               │ debg TestSubjects.find(kibanaChrome)
[00:01:03]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:01:03]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:195249 Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE].
[00:01:03]               │          at ui_actions_service_UiActionsService.attachAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:58756)
[00:01:03]               │          at ui_actions_service_UiActionsService.addTriggerAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:59571)
[00:01:03]               │          at plugin_DataPublicPlugin.setup (http://localhost:61141/37681/bundles/plugin/data/data.plugin.js:8:233403)
[00:01:03]               │          at _callee$ (http://localhost:61141/37681/bundles/core/core.entry.js:13:252168)
[00:01:03]               │          at l (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968491)
[00:01:03]               │          at Generator._invoke (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968244)
[00:01:03]               │          at Generator.forEach.e.<computed> [as next] (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968848)
[00:01:03]               │          at plugin_asyncGeneratorStep (http://localhost:61141/37681/bundles/core/core.entry.js:13:250272)
[00:01:03]               │          at _next (http://localhost:61141/37681/bundles/core/core.entry.js:13:250589)
[00:01:03]               │ debg browser[INFO] http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 390:89301 "Version 9 of Highlight.js has reached EOL and is no longer supported.
[00:01:03]               │      Please upgrade or ask whatever dependency you are using to upgrade.
[00:01:03]               │      https://github.com/highlightjs/highlight.js/issues/2877"
[00:01:03]               │ debg browser[INFO] http://localhost:61141/37681/bundles/core/core.entry.js 12:196196 "Detected an unhandled Promise rejection.
[00:01:03]               │      Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE]."
[00:01:03]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:357477 Uncaught Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exis…ttaching action [actionId = ACTION_SELECT_RANGE].
[00:02:04]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
[00:02:04]               │      Wait timed out after 60071ms
[00:02:04]               │ debg --- retry.tryForTime error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
[00:02:04]               │      Wait timed out after 60071ms
[00:02:04]               │          at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:02:04]               │          at runMicrotasks (<anonymous>)
[00:02:04]               │          at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:02:05]               │ debg navigate to: http://localhost:61141/app/home
[00:02:05]               │ debg browser[INFO] http://localhost:61141/app/home?_t=1609874734305 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:05]               │
[00:02:05]               │ debg browser[INFO] http://localhost:61141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:05]               │ debg ... sleep(700) start
[00:02:05]               │ debg ... sleep(700) end
[00:02:05]               │ debg returned from get, calling refresh
[00:02:05]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:195249 Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE].
[00:02:05]               │          at ui_actions_service_UiActionsService.attachAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:58756)
[00:02:05]               │          at ui_actions_service_UiActionsService.addTriggerAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:59571)
[00:02:05]               │          at plugin_DataPublicPlugin.setup (http://localhost:61141/37681/bundles/plugin/data/data.plugin.js:8:233403)
[00:02:05]               │          at _callee$ (http://localhost:61141/37681/bundles/core/core.entry.js:13:252168)
[00:02:05]               │          at l (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968491)
[00:02:05]               │          at Generator._invoke (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968244)
[00:02:05]               │          at Generator.forEach.e.<computed> [as next] (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968848)
[00:02:05]               │          at plugin_asyncGeneratorStep (http://localhost:61141/37681/bundles/core/core.entry.js:13:250272)
[00:02:05]               │          at _next (http://localhost:61141/37681/bundles/core/core.entry.js:13:250589)
[00:02:06]               │ debg browser[INFO] http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 390:89301 "Version 9 of Highlight.js has reached EOL and is no longer supported.
[00:02:06]               │      Please upgrade or ask whatever dependency you are using to upgrade.
[00:02:06]               │      https://github.com/highlightjs/highlight.js/issues/2877"
[00:02:06]               │ debg browser[INFO] http://localhost:61141/37681/bundles/core/core.entry.js 12:196196 "Detected an unhandled Promise rejection.
[00:02:06]               │      Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE]."
[00:02:06]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:357477 Uncaught Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exis…ttaching action [actionId = ACTION_SELECT_RANGE].
[00:02:06]               │ debg browser[INFO] http://localhost:61141/app/home?_t=1609874734305 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:06]               │
[00:02:06]               │ debg browser[INFO] http://localhost:61141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:06]               │ debg currentUrl = http://localhost:61141/app/home
[00:02:06]               │          appUrl = http://localhost:61141/app/home
[00:02:06]               │ debg TestSubjects.find(kibanaChrome)
[00:02:06]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:06]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:195249 Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE].
[00:02:06]               │          at ui_actions_service_UiActionsService.attachAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:58756)
[00:02:06]               │          at ui_actions_service_UiActionsService.addTriggerAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:59571)
[00:02:06]               │          at plugin_DataPublicPlugin.setup (http://localhost:61141/37681/bundles/plugin/data/data.plugin.js:8:233403)
[00:02:06]               │          at _callee$ (http://localhost:61141/37681/bundles/core/core.entry.js:13:252168)
[00:02:06]               │          at l (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968491)
[00:02:06]               │          at Generator._invoke (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968244)
[00:02:06]               │          at Generator.forEach.e.<computed> [as next] (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968848)
[00:02:06]               │          at plugin_asyncGeneratorStep (http://localhost:61141/37681/bundles/core/core.entry.js:13:250272)
[00:02:06]               │          at _next (http://localhost:61141/37681/bundles/core/core.entry.js:13:250589)
[00:02:06]               │ debg browser[INFO] http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 390:89301 "Version 9 of Highlight.js has reached EOL and is no longer supported.
[00:02:06]               │      Please upgrade or ask whatever dependency you are using to upgrade.
[00:02:06]               │      https://github.com/highlightjs/highlight.js/issues/2877"
[00:02:06]               │ debg browser[INFO] http://localhost:61141/37681/bundles/core/core.entry.js 12:196196 "Detected an unhandled Promise rejection.
[00:02:06]               │      Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE]."
[00:02:06]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:357477 Uncaught Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exis…ttaching action [actionId = ACTION_SELECT_RANGE].
[00:03:06]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
[00:03:06]               │      Wait timed out after 60115ms
[00:03:06]               │ debg navigate to: http://localhost:61141/app/home
[00:03:06]               │ debg browser[INFO] http://localhost:61141/app/home?_t=1609874796123 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:06]               │
[00:03:06]               │ debg browser[INFO] http://localhost:61141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:06]               │ debg ... sleep(700) start
[00:03:07]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:195249 Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE].
[00:03:07]               │          at ui_actions_service_UiActionsService.attachAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:58756)
[00:03:07]               │          at ui_actions_service_UiActionsService.addTriggerAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:59571)
[00:03:07]               │          at plugin_DataPublicPlugin.setup (http://localhost:61141/37681/bundles/plugin/data/data.plugin.js:8:233403)
[00:03:07]               │          at _callee$ (http://localhost:61141/37681/bundles/core/core.entry.js:13:252168)
[00:03:07]               │          at l (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968491)
[00:03:07]               │          at Generator._invoke (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968244)
[00:03:07]               │          at Generator.forEach.e.<computed> [as next] (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968848)
[00:03:07]               │          at plugin_asyncGeneratorStep (http://localhost:61141/37681/bundles/core/core.entry.js:13:250272)
[00:03:07]               │          at _next (http://localhost:61141/37681/bundles/core/core.entry.js:13:250589)
[00:03:07]               │ debg browser[INFO] http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 390:89301 "Version 9 of Highlight.js has reached EOL and is no longer supported.
[00:03:07]               │      Please upgrade or ask whatever dependency you are using to upgrade.
[00:03:07]               │      https://github.com/highlightjs/highlight.js/issues/2877"
[00:03:07]               │ debg ... sleep(700) end
[00:03:07]               │ debg returned from get, calling refresh
[00:03:07]               │ debg browser[INFO] http://localhost:61141/37681/bundles/core/core.entry.js 12:196196 "Detected an unhandled Promise rejection.
[00:03:07]               │      Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE]."
[00:03:07]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:357477 Uncaught Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exis…ttaching action [actionId = ACTION_SELECT_RANGE].
[00:03:07]               │ debg browser[INFO] http://localhost:61141/app/home?_t=1609874796123 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:07]               │
[00:03:07]               │ debg browser[INFO] http://localhost:61141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:08]               │ debg currentUrl = http://localhost:61141/app/home
[00:03:08]               │          appUrl = http://localhost:61141/app/home
[00:03:08]               │ debg TestSubjects.find(kibanaChrome)
[00:03:08]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:03:08]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:195249 Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE].
[00:03:08]               │          at ui_actions_service_UiActionsService.attachAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:58756)
[00:03:08]               │          at ui_actions_service_UiActionsService.addTriggerAction (http://localhost:61141/37681/bundles/plugin/uiActions/uiActions.plugin.js:1:59571)
[00:03:08]               │          at plugin_DataPublicPlugin.setup (http://localhost:61141/37681/bundles/plugin/data/data.plugin.js:8:233403)
[00:03:08]               │          at _callee$ (http://localhost:61141/37681/bundles/core/core.entry.js:13:252168)
[00:03:08]               │          at l (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968491)
[00:03:08]               │          at Generator._invoke (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968244)
[00:03:08]               │          at Generator.forEach.e.<computed> [as next] (http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968848)
[00:03:08]               │          at plugin_asyncGeneratorStep (http://localhost:61141/37681/bundles/core/core.entry.js:13:250272)
[00:03:08]               │          at _next (http://localhost:61141/37681/bundles/core/core.entry.js:13:250589)
[00:03:08]               │ debg browser[INFO] http://localhost:61141/37681/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 390:89301 "Version 9 of Highlight.js has reached EOL and is no longer supported.
[00:03:08]               │      Please upgrade or ask whatever dependency you are using to upgrade.
[00:03:08]               │      https://github.com/highlightjs/highlight.js/issues/2877"
[00:03:08]               │ debg browser[INFO] http://localhost:61141/37681/bundles/core/core.entry.js 12:196196 "Detected an unhandled Promise rejection.
[00:03:08]               │      Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE]."
[00:03:08]               │ERROR browser[SEVERE] http://localhost:61141/37681/bundles/core/core.entry.js 12:357477 Uncaught Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exis…ttaching action [actionId = ACTION_SELECT_RANGE].
[00:04:08]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
[00:04:08]               │      Wait timed out after 60052ms
[00:04:08]               │ debg --- retry.tryForTime error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
[00:04:08]               │      Wait timed out after 60052ms
[00:04:08]               │          at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:04:08]               │          at runMicrotasks (<anonymous>)
[00:04:08]               │          at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:04:09]               │ info Taking screenshot "/dev/shm/workspace/parallel/14/kibana/test/security_functional/screenshots/failure/Security OSS Insecure Cluster Warning _before all_ hook.png"
[00:04:09]               │ info Current URL is: http://localhost:61141/app/home
[00:04:09]               │ info Saving page source to: /dev/shm/workspace/parallel/14/kibana/test/security_functional/failure_debug/html/Security OSS Insecure Cluster Warning _before all_ hook.html
[00:04:09]               └- ✖ fail: Security OSS Insecure Cluster Warning "before all" hook in "Insecure Cluster Warning"
[00:04:09]               │      retry.tryForTime timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
[00:04:09]               │ Wait timed out after 60052ms
[00:04:09]               │     at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:04:09]               │     at runMicrotasks (<anonymous>)
[00:04:09]               │     at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:04:09]               │     at onFailure (/dev/shm/workspace/parallel/14/kibana/test/common/services/retry/retry_for_success.ts:28:9)
[00:04:09]               │     at retryForSuccess (/dev/shm/workspace/parallel/14/kibana/test/common/services/retry/retry_for_success.ts:68:13)
[00:04:09]               │     at Retry.try (/dev/shm/workspace/parallel/14/kibana/test/common/services/retry/retry.ts:43:14)
[00:04:09]               │     at /dev/shm/workspace/parallel/14/kibana/test/functional/page_objects/common_page.ts:238:23
[00:04:09]               │     at runAttempt (/dev/shm/workspace/parallel/14/kibana/test/common/services/retry/retry_for_success.ts:38:15)
[00:04:09]               │     at retryForSuccess (/dev/shm/workspace/parallel/14/kibana/test/common/services/retry/retry_for_success.ts:77:21)
[00:04:09]               │     at Retry.tryForTime (/dev/shm/workspace/parallel/14/kibana/test/common/services/retry/retry.ts:34:14)
[00:04:09]               │     at CommonPage.navigateToApp (/dev/shm/workspace/parallel/14/kibana/test/functional/page_objects/common_page.ts:237:7)
[00:04:09]               │     at Context.<anonymous> (/dev/shm/workspace/parallel/14/kibana/test/security_functional/insecure_cluster_warning.ts:31:7)
[00:04:09]               │     at Object.apply (/dev/shm/workspace/parallel/14/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)
[00:04:09]               │   Error: retry.tryForTime timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
[00:04:09]               │   Wait timed out after 60052ms
[00:04:09]               │       at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:04:09]               │       at runMicrotasks (<anonymous>)
[00:04:09]               │       at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:04:09]               │       at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
[00:04:09]               │       at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)
[00:04:09]               │       at Retry.try (test/common/services/retry/retry.ts:43:14)
[00:04:09]               │       at /dev/shm/workspace/parallel/14/kibana/test/functional/page_objects/common_page.ts:238:23
[00:04:09]               │       at runAttempt (test/common/services/retry/retry_for_success.ts:38:15)
[00:04:09]               │       at retryForSuccess (test/common/services/retry/retry_for_success.ts:77:21)
[00:04:09]               │       at Retry.tryForTime (test/common/services/retry/retry.ts:34:14)
[00:04:09]               │       at CommonPage.navigateToApp (test/functional/page_objects/common_page.ts:237:7)
[00:04:09]               │       at Context.<anonymous> (test/security_functional/insecure_cluster_warning.ts:31:7)
[00:04:09]               │       at Object.apply (packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)
[00:04:09]               │       at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
[00:04:09]               │       at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)
[00:04:09]               │       at Retry.tryForTime (test/common/services/retry/retry.ts:34:14)
[00:04:09]               │       at CommonPage.navigateToApp (test/functional/page_objects/common_page.ts:237:7)
[00:04:09]               │       at Context.<anonymous> (test/security_functional/insecure_cluster_warning.ts:31:7)
[00:04:09]               │       at Object.apply (packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)
[00:04:09]               │ 
[00:04:09]               │

Stack Trace

Error: retry.tryForTime timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
Wait timed out after 60052ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)
    at Retry.try (test/common/services/retry/retry.ts:43:14)
    at /dev/shm/workspace/parallel/14/kibana/test/functional/page_objects/common_page.ts:238:23
    at runAttempt (test/common/services/retry/retry_for_success.ts:38:15)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:77:21)
    at Retry.tryForTime (test/common/services/retry/retry.ts:34:14)
    at CommonPage.navigateToApp (test/functional/page_objects/common_page.ts:237:7)
    at Context.<anonymous> (test/security_functional/insecure_cluster_warning.ts:31:7)
    at Object.apply (packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)
    at Retry.tryForTime (test/common/services/retry/retry.ts:34:14)
    at CommonPage.navigateToApp (test/functional/page_objects/common_page.ts:237:7)
    at Context.<anonymous> (test/security_functional/insecure_cluster_warning.ts:31:7)
    at Object.apply (packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -26.9KB

Distributable file count

id before after diff
default 47592 48355 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 48.6KB 48.7KB +80.0B
triggersActionsUi 162.5KB 162.6KB +102.0B
total +182.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gmmorris
Copy link
Contributor Author

gmmorris commented Jan 7, 2021

The original PR was reverted

@gmmorris gmmorris closed this Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmmorris @kibanamachine