Skip to content

[ML] Data Frame Analytics: Scatterplot Matrix Fixes #86357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 21, 2020
Merged

[ML] Data Frame Analytics: Scatterplot Matrix Fixes #86357

merged 6 commits into from
Dec 21, 2020

Conversation

@walterra
Copy link
Contributor

@walterra walterra commented Dec 17, 2020

Summary

Part of #84420

  • use ml API service from the Kibana context
  • adds jest tests for the Vega Lite Spec generator
  • fix chart layout overflow with too many fields selected

Checklist

@walterra walterra added bug Fixes for quality problems that affect the customer experience :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v7.11.0 v7.12.0 labels Dec 17, 2020
@walterra walterra self-assigned this Dec 17, 2020
@walterra walterra requested review from a team as code owners December 17, 2020 19:19
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 17, 2020

Pinging @elastic/ml-ui (:ml)

@walterra walterra mentioned this pull request Dec 18, 2020
Open
41 tasks
@walterra walterra requested a review from darnautov December 18, 2020 15:13
peteharverson
peteharverson approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darnautov
Copy link
Contributor

darnautov commented Dec 21, 2020

@elasticmachine merge upstream

darnautov
darnautov approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra
Copy link
Contributor Author

walterra commented Dec 21, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 21, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 7.0MB 7.0MB +309.0B

Distributable file count

id before after diff
default 47142 47902 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit d744eae into elastic:master Dec 21, 2020
@walterra walterra deleted the ml-scatterplot-fixes branch December 21, 2020 14:22
@walterra walterra mentioned this pull request Dec 21, 2020
Merged
walterra added a commit to walterra/kibana that referenced this pull request Dec 21, 2020
@walterra
[ML] Data Frame Analytics: Scatterplot Matrix Fixes (elastic#86357)
0feee71 
- use ml API service from the Kibana context
- adds jest tests for the Vega Lite Spec generator
- fix chart layout overflow with too many fields selected
@walterra walterra mentioned this pull request Dec 21, 2020
Merged
walterra added a commit to walterra/kibana that referenced this pull request Dec 21, 2020
@walterra
[ML] Data Frame Analytics: Scatterplot Matrix Fixes (elastic#86357)
ea3ddbb 
- use ml API service from the Kibana context
- adds jest tests for the Vega Lite Spec generator
- fix chart layout overflow with too many fields selected
walterra added a commit that referenced this pull request Dec 21, 2020
@walterra
[ML] Data Frame Analytics: Scatterplot Matrix Fixes (#86357) (#86649)
e94e876 
- use ml API service from the Kibana context
- adds jest tests for the Vega Lite Spec generator
- fix chart layout overflow with too many fields selected
walterra added a commit that referenced this pull request Dec 21, 2020
@walterra
[ML] Data Frame Analytics: Scatterplot Matrix Fixes (#86357) (#86648)
0c872a7 
- use ml API service from the Kibana context
- adds jest tests for the Vega Lite Spec generator
- fix chart layout overflow with too many fields selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@darnautov darnautov darnautov approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@walterra walterra

Labels

bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@walterra @elasticmachine @darnautov @kibanamachine @ryankeairns @peteharverson