-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Maps] Add percentile #85367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Add percentile #85367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am able to consistently make the features disappear with the following steps
- Create a new map
- Add clusters layer
- Change count aggregation to percentile
- Slowly move slider to the right trying to set to 90th.
- At some point, the map stops showing clusters and there are no errors in the console. See the screen shot below. There should be clusters since there is data for the past 24 hours and no filters are applied.
x-pack/plugins/maps/public/components/metrics_editor/metric_select.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/metrics_editor/metric_editor.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/metrics_editor/metric_editor.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/metrics_editor/metric_editor.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/metrics_editor/metric_editor.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/metrics_editor/validated_number_input.tsx
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/metrics_editor/validated_number_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/validated_number_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/validated_number_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/validated_number_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/validated_number_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/validated_number_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/validated_number_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/validated_number_input.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/validated_number_input.tsx
Outdated
Show resolved
Hide resolved
nreese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a few nits to clean up
code review, tested in chrome
x-pack/plugins/maps/public/components/validated_number_input.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |

Summary
Closes #78592
Adds the ability to compute a percentile for agg-sources. Can be used for cluster/grid layers and in term joins.
Users can set the percentage explicitly. When set to
50, it computes the median.Internal users of the
MapsEmbeddablecan add this to their layer-descriptor:e.g. for a choropleth-map, in the
joins-property:This can then be refered back to by its unique name in the style-descriptors.
e.g. fill-color
Checklist
Delete any items that are not applicable to this PR.
For maintainers