chore(NA): upgrade node-sass into v4.14.1 to stop shipping old node-gyp #84935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
marius-dr
approved these changes
Dec 3, 2020
Member
marius-dr
left a comment
marius-dr
left a comment
There was a problem hiding this comment.
LGTM. It was at least easier than the Node 12 transition
1 task
mistic
changed the title
kindsun
approved these changes
Dec 3, 2020
Contributor
kindsun
left a comment
kindsun
left a comment
There was a problem hiding this comment.
I was having the same issue on Ubuntu 20.04.1 LTS. Confirmed this fix worked in this environment. lgtm w/ green CI!
mistic
force-pushed
the
upgrade-node-sass
branch
from
80f017c to
2aeea11
Compare
mistic
changed the title
Member
Author
|
I was trying to upgrade directly into |
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Member
Author
|
7.x: d17299e |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Dec 4, 2020
…ode-gyp (elastic#84935) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 4, 2020
…fields * 'master' of github.com:elastic/kibana: [ILM] Fix delete phase serialization bug (elastic#84870) chore(NA): removes auto install of pre-commit hook (elastic#83566) chore(NA): upgrade node-sass into last v4.14.1 to stop shipping old node-gyp (elastic#84935) [Alerting] Enables AlertTypes to define the custom recovery action groups (elastic#84408) [ML] Functional tests - add missing test data cleanup (elastic#84998) Migrate privilege/role/user-related operations to a new Elasticsearch client. (elastic#84641) # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/deserializer_and_serializer.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/serializer/serializer.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like after #83425 @peteharverson was not being able to bootstrap on
windows. I was suspecting the problem was caused by some oldnode-gypversion installed and @marius-dr found the version ofnode-sasswe were using ships with an old version of it. That PR intends to solve the mentioned issue by upgradingnode-sassto its latest version which ships with a newernode-gypversion.