[Maps] keep local metrics editor state and only submit metrics to redux store when valid #84828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s state when valid
nreese
added
chore
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
changed the title
nreese
changed the title
Contributor
Author
|
@elasticmachine merge upstream |
2 tasks
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
thomasneirynck
approved these changes
Dec 8, 2020
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
thx for the refactor. this is a really nice pattern, and should remember it going forward for all our forms, not to try and clutter redux-store with invalid state.
x-pack/plugins/maps/public/components/metrics_editor/metric_editor.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Dec 9, 2020
…ux store when valid (elastic#84828) * [Maps] keep invalid metrics editor state local and only submit metrics state when valid * review feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Dec 9, 2020
…ux store when valid (#84828) (#85437) * [Maps] keep invalid metrics editor state local and only submit metrics state when valid * review feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help remove edge cases that #83586 has to handle by only pushing valid metrics to redux instead of pushing all metric state changes to redux.
For example, prior to this PR, redux would get updated twice, the first time with invalid state.
Change aggregation type from 'count' to 'avg'
push redux with invalid metric { type: 'avg' }
Select field
push redux with metric { type: 'avg', field: 'my field' }
With this PR, now there is only a single redux state change
Change aggregation type from 'count' to 'avg'
update local state with metric { type: 'avg' }
Select field
update local state with metric { type: 'avg', field: 'my field' }
push local state to redux state