Skip to content

[Lens] Fix error when selecting the current field again #84817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2020
Merged

[Lens] Fix error when selecting the current field again #84817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_panel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,6 +1229,24 @@ describe('IndexPatternDimensionEditorPanel', () => {
);
});

it('should not update when selecting the current field again', () => {
wrapper = mount(<IndexPatternDimensionEditorComponent {...defaultProps} />);

const comboBox = wrapper
.find(EuiComboBox)
.filter('[data-test-subj="indexPattern-dimension-field"]');

const option = comboBox
.prop('options')![1]
.options!.find(({ label }) => label === 'timestampLabel')!;

act(() => {
comboBox.prop('onChange')!([option]);
});

expect(setState).not.toHaveBeenCalled();
});

it('should show all operations that are not filtered out', () => {
wrapper = mount(
<IndexPatternDimensionEditorComponent
Expand Down
7 changes: 5 additions & 2 deletions x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/field_select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,12 @@ export function FieldSelect({
return;
}

trackUiEvent('indexpattern_dimension_field_changed');
const choice = (choices[0].value as unknown) as FieldChoice;

onChoose((choices[0].value as unknown) as FieldChoice);
if (choice.field !== selectedField) {
trackUiEvent('indexpattern_dimension_field_changed');
onChoose(choice);
}
}}
renderOption={(option, searchValue) => {
return (
Expand Down