-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Telemetry for Dynamic Actions (Drilldowns) #84580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
ppisljar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the telemetry function should work like a reduce, where your stats argument is the accumulator, and i think we should do that on inner layers as well.
x-pack/plugins/ui_actions_enhanced/server/telemetry/dynamic_action_factories_collector.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ui_actions_enhanced/server/telemetry/dynamic_action_factories_collector.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ui_actions_enhanced/server/telemetry/dynamic_actions_collector.ts
Show resolved
Hide resolved
x-pack/plugins/ui_actions_enhanced/server/dynamic_action_enhancement.ts
Outdated
Show resolved
Hide resolved
ppisljar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
* feat: 🎸 set up telemetry for UiActions * feat: 🎸 improve ui_actions_enhanced collector * feat: 🎸 namespace ui actions telemetry stats * refactor: 💡 improve dynamic actions collector setup * feat: 🎸 add tests for dynamicActionsCollector * feat: 🎸 collect dynamic action trigger statistics * refactor: 💡 standartize metric naming * feat: 🎸 aggregate action x trigger counts * test: 💍 add tests for factory stats * docs: ✏️ add ui actions enhanced telemetry docs * fix: 🐛 revert type change * refactor: 💡 make dynamic action stats global * refactor: 💡 use global telemetry stats in action factories Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💔 Build Failed
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Closes #78402
This PR integrate
.telemetry()from PersistedState service to track the following metrics..telemetry()method of persistable state service which is wired intoui_actions_enhanced.Checklist
For maintainers
Release note
Adds telemetry tracking for dynamic UI Actions. Now number of drilldowns used on dashboard and type of the drilldowns is aggregated and reported using telemetry.
Documentation
Dynamic Actions Telemetry
Dynamic actions (drilldowns) report telemetry. Below is the summary of dynamic action metrics that are reported using telemetry.
Dynamic action count
Total count of dynamic actions (drilldowns) on a saved object.
Count by factory ID
Count of active dynamic actions (drilldowns) on a saved object by factory ID (drilldown type).
For example:
Count by trigger
Count of active dynamic actions (drilldowns) on a saved object by a trigger to which they are attached.
For example:
Count by factory and trigger
Count of active dynamic actions (drilldowns) on a saved object by a factory ID and trigger ID.
For example:
Factory metrics
Each dynamic action factory (drilldown type) can report its own stats, which is
done using the
.telemetry()method on dynamic action factories.