[TSVB] [Rollup] Table tab not working with rollup indexes #83635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
reviewed
Nov 18, 2020
src/plugins/vis_type_timeseries/public/application/components/panel_config/table.js
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Nov 19, 2020
| SUM: 'sum', | ||
| }; | ||
| // We should probably use METRIC_TYPES from data plugin in future. | ||
| export enum METRIC_TYPES { |
VladLasitsa
added
Feature:TSVB
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
sulemanof
approved these changes
Nov 20, 2020
Contributor
sulemanof
left a comment
sulemanof
left a comment
There was a problem hiding this comment.
LGTM, checked out locally, works as expected 👍
stratoula
approved these changes
Nov 20, 2020
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
LGTM tested locally and the bug is solved
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to rudolf/kibana
that referenced
this pull request
Nov 23, 2020
* master: (67 commits) [Observability] Load hasData call asynchronously (elastic#80644) Implement AnonymousAuthenticationProvider. (elastic#79985) Deprecate `visualization:colorMapping` advanced setting (elastic#83372) [TSVB] [Rollup] Table tab not working with rollup indexes (elastic#83635) Revert "[Search] Search batching using bfetch (elastic#83418)" (elastic#84037) skip flaky suite (elastic#83772) skip flaky suite (elastic#69849) create kbn-legacy-logging package (elastic#77678) [Search] Search batching using bfetch (elastic#83418) [Security Solution] Refactor Timeline flyout to take a full page (elastic#82033) Drop use of console-stamp (elastic#83922) skip flaky suite (elastic#84011 , elastic#84012) Fixed usage of `isReady` for usage collection of alerts and actions (elastic#83760) [maps] support URL drilldowns (elastic#83732) Revert "Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)" [code coverage] Update jest config to collect more data (elastic#83804) Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226) [Security Solution] Give notice when endpoint policy is out of date (elastic#83469) [Security Solution] Sync url state on any changes to query string (elastic#83314) [CI] Initial TeamCity implementation (elastic#81043) ...
VladLasitsa
added a commit
that referenced
this pull request
Nov 24, 2020
…84047) * Added restrictions and type to filtering filed for group by * Use context instead of consumer * Added bucket types Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #83414
Summary
Added restrictions and type to filtering fields for 'group by'
Checklist
Delete any items that are not applicable to this PR.
For maintainers