Skip to content

Conversation

@streamich
Copy link
Contributor

Summary

Adds ability to not encode URL in URL Drilldown.

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default - 42777 +42777

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uiActionsEnhanced 304.4KB 305.2KB +866.0B
urlDrilldown 13.9KB 14.0KB +116.0B
total +982.0B
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
css - 650.1KB ⚠️ +650.1KB
kbn-ui-shared-deps.@elastic.js - 2.4MB ⚠️ +2.4MB
kbn-ui-shared-deps.js - 4.8MB ⚠️ +4.8MB
total ⚠️ +7.9MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich
Copy link
Contributor Author

streamich commented Nov 12, 2020

  • design with "Advanced settings"
    • extra explanations text next to checkboxes
  • encode helpers, 2 of them (+ and %20) src/plugins/kibana_utils/common/url/encode_uri_query.ts
  • add usage examples to public docs, which have full examples of Handlebars usage

@mdefazio
Copy link
Contributor

I gave this a bit more thought and here is another option. I have the advanced settings (Maybe 'Additional options' is less scary?) below the 'Open in new tab' option since it seemed to make sense that we expose options first and then have additional hidden options below.

image

@elastic-jb
Copy link

@streamich This looks good to me. I would like to bring in one more thought after talking through it with @mdefazio . Nearly every time I am turning on "open in a new window" because I can view the extra information, close the tab and be back where I was without accidentally closing it before going back. I think that's a better default.

Additionally, we were talking about the "additional options" section being a good place for things we want on by default, but users might want ti disable. I think we should include "Open in new Window" in that as well.

@streamich
Copy link
Contributor Author

#86902

@streamich streamich closed this Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants