Skip to content

[Index management] Fix test in index template wizard #83150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2020
Merged

[Index management] Fix test in index template wizard #83150

merged 1 commit into from
Nov 11, 2020

Conversation

@sebelga
Copy link
Contributor

@sebelga sebelga commented Nov 11, 2020

This PR fixes an issue in one of our component integration tests of index template.

It was discovered by @watson and commented here https://github.com/elastic/kibana/pull/61587/files#r520317329

@sebelga sebelga added failed-test A test failure on a tracked branch, potentially flaky-test Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.11 v8.0.0 labels Nov 11, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2020

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@sebelga sebelga added the Feature:Index Management Index and index templates UI label Nov 11, 2020
@sebelga sebelga changed the title [Index managment] Fix test in index template wizard [Index management] Fix test in index template wizard Nov 11, 2020
@sebelga sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Nov 11, 2020
@sebelga sebelga requested a review from yuliacech November 11, 2020 09:08
@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 11, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sebelga , changes LGTM! nice work fixing this test 👍

@sebelga
Copy link
Contributor Author

sebelga commented Nov 11, 2020

Thanks for the review @yuliacech ! 👍

@sebelga sebelga merged commit 244ce85 into elastic:master Nov 11, 2020
@sebelga sebelga deleted the fix-index-template-test branch November 11, 2020 14:52
@sebelga sebelga mentioned this pull request Nov 11, 2020
Merged
sebelga added a commit that referenced this pull request Nov 12, 2020
@sebelga
[7.x] [Index management] Fix test in index template wizard (#83150) (#…
a37733f 
…83173)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

failed-test A test failure on a tracked branch, potentially flaky-test Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebelga @elasticmachine @kibanamachine @yuliacech