Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APM index settings import/export in saved-object management #82784

Merged
merged 4 commits into from
Nov 23, 2020
Merged

APM index settings import/export in saved-object management #82784

merged 4 commits into from
Nov 23, 2020

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Nov 5, 2020

apm-indices

Resolves #82538

"Release Note: APM Index Settings can now be imported/exported using saved-object management"

@kobelb kobelb requested a review from sorenlouv November 5, 2020 21:32
@kobelb kobelb requested a review from a team as a code owner November 5, 2020 21:32
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Nov 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kobelb
Copy link
Contributor Author

kobelb commented Nov 5, 2020 •
edited
Loading

@sqren I guessed at the icon and text we should be using here, I won't be offended if you'd like me to make changes, or if you'd like me to just abandon this PR :)

@kobelb kobelb mentioned this pull request Nov 5, 2020
Closed
sorenlouv
sorenlouv approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thanks!

sorenlouv
sorenlouv reviewed Nov 5, 2020
View reviewed changes
x-pack/plugins/apm/server/saved_objects/apm_indices.ts Outdated
management: {
importableAndExportable: true,
icon: 'apmApp',
getTitle: () => 'APM Settings - Indices',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be translated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, lemme check the other titles

@kobelb
Copy link
Contributor Author

kobelb commented Nov 20, 2020

@elasticmachine merge upstream

@kobelb
Copy link
Contributor Author

kobelb commented Nov 23, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kobelb kobelb merged commit e3adae4 into elastic:master Nov 23, 2020
@kobelb kobelb deleted the apm-export branch November 23, 2020 17:01
@kobelb kobelb mentioned this pull request Nov 23, 2020
Merged
kobelb added a commit that referenced this pull request Nov 23, 2020
@kobelb @kibanamachine
APM index settings import/export in saved-object management (#82784) (#…
d9a2162 
…84122)

* APM index settings import/export in saved-object management

* i18n'ing the title

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import and export apm-indices using saved-object management
4 participants
@kobelb @elasticmachine @kibanamachine @sorenlouv