Skip to content

[Discover] Unskip and improve functional doc_table tests #82430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 24, 2020
Merged

[Discover] Unskip and improve functional doc_table tests #82430

merged 7 commits into from
Nov 24, 2020

Conversation

@kertal
Copy link
Member

@kertal kertal commented Nov 3, 2020 •
edited
Loading

Summary

Improve the test a bit by setting the default time range once by UiSettings and not between each test. No more flakiness, 300 runs:

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1017/

Fixes #82445
Fixes #81865

Checklist

Delete any items that are not applicable to this PR.

@kertal kertal changed the title [Discover] Unskip functional doc_table test [Discover] Unskip and improve functional doc_table tests Nov 3, 2020
@kertal kertal mentioned this pull request Nov 3, 2020
Merged
1 task
@kertal
Copy link
Member Author

kertal commented Nov 12, 2020

@elasticmachine merge upstream

@kertal
Copy link
Member Author

kertal commented Nov 23, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 23, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal self-assigned this Nov 23, 2020
@kertal kertal added Feature:Discover Discover Application Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.11.0 v8.0.0 labels Nov 23, 2020
@kertal kertal marked this pull request as ready for review November 23, 2020 20:39
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 23, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal added the release_note:skip Skip the PR/issue when compiling release notes label Nov 24, 2020
@kertal kertal requested a review from dmlemeshko November 24, 2020 09:42
dmlemeshko
dmlemeshko approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍

@kertal kertal merged commit 7156a57 into elastic:master Nov 24, 2020
@kertal kertal mentioned this pull request Nov 24, 2020
Merged
kertal added a commit to kertal/kibana that referenced this pull request Nov 24, 2020
@kertal
[Discover] Unskip and improve functional doc_table tests (elastic#82430)
97731d7
kertal added a commit that referenced this pull request Nov 24, 2020
@kertal
[Discover] Unskip and improve functional doc_table tests (#82430) (#8…
518c24d 
…4197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@dej611 dej611 Awaiting requested review from dej611

@mistic mistic Awaiting requested review from mistic

@tylersmalley tylersmalley Awaiting requested review from tylersmalley

Assignees

@kertal kertal

Labels

Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

4 participants

@kertal @kibanamachine @elasticmachine @dmlemeshko