Add globalNav styles that prevent the nav items from overlapping when the window is very short. #8196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the window is very short, and instead allows the user to scroll.
cjcenizal
force-pushed
the
improvement/scrolling-nav-overflow
branch
from
0256933
to
9ce2cd5
Compare
|
i tested this in IE11 and EDGE ... in both it works ok. |
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Sep 9, 2016
--------- **Commit 1:** Add globalNav styles that prevent the nav items from overlapping when the window is very short, and instead allows the user to scroll. * Original sha: 9ce2cd5 * Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-09T03:28:45Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead the user can scroll to bring clipped nav items into view.
NOTE: I haven't been able to test this in IE due to problems with my VM.
Original problem
Solution