Skip to content

[Security Solution][Detections] Fix error causing ml rules telemetry to be discarded #81945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020
Merged

[Security Solution][Detections] Fix error causing ml rules telemetry to be discarded #81945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/server/usage/detections/detections_helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export const getMlJobsUsage = async (ml: MlPluginSetup | undefined): Promise<MlJ

if (ml) {
try {
const fakeRequest = {} as KibanaRequest;
const fakeRequest = { headers: {} } as KibanaRequest;
Copy link
Contributor

@FrankHassanabad FrankHassanabad Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this part need to be fixed as well?
https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/server/lib/detection_engine/signals/signal_rule_alert_type.ts#L212

Copy link
Contributor Author

@rylnd rylnd Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! For now, it's only the modulesProvider that performs the additional headers check, the jobsProvider (and thus ML Rule execution) continues to function as expected.

const fakeSOClient = {} as SavedObjectsClient;

const modules = await ml.modulesProvider(fakeRequest, fakeSOClient).listModules();
Expand Down