Skip to content

adds Alerts & Actions to the app directory #81902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2020
Merged

adds Alerts & Actions to the app directory #81902

merged 2 commits into from
Oct 29, 2020

Conversation

@gmmorris
Copy link
Contributor

@gmmorris gmmorris commented Oct 28, 2020 •
edited
Loading

Summary

closes #80532

Adds a link to the Alerts & Actions from the app directory

Screenshot 2020-10-28 at 17 12 01

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@gmmorris
Copy link
Contributor Author

gmmorris commented Oct 28, 2020

@elasticmachine merge upstream

@gmmorris gmmorris changed the title added alerting to app directory adds Alerts & Actions to the app directory Oct 28, 2020
@gmmorris gmmorris added Feature:Alerting release_note:enhancement Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.11.0 v8.0.0 labels Oct 28, 2020
@gmmorris gmmorris marked this pull request as ready for review October 28, 2020 18:14
@gmmorris gmmorris requested a review from a team as a code owner October 28, 2020 18:14
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 28, 2020

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko
YulNaumenko approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It would be nice to have some e2e test which is ensure that we have the link from which can direct to Alerts management.

ymao1
ymao1 approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hardest part for me was finding the app directory :)

@gmmorris
Copy link
Contributor Author

gmmorris commented Oct 29, 2020 •
edited
Loading

LGTM! It would be nice to have some e2e test which is ensure that we have the link from which can direct to Alerts management.

Agreed, and I looked, but there doesn't seem to be any equivalent by any of the other applications and as we're simply plugging into another feature's logic I'm not sure how best to actually test this without it being very breakable.

I only found one e2e test for this anywhere and it is skipped :/
I've decided to align with other plugin's usage and treat this as an external feature that we don't test.

@gmmorris gmmorris merged commit d1344b6 into elastic:master Oct 29, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 29, 2020
@gmmorris
added alerting to app directory (elastic#81902)
4ebb0d7 
Adds a link to the  Alerts & Actions from the app directory
@gmmorris gmmorris mentioned this pull request Oct 29, 2020
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 29, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
triggersActionsUi 1.5MB 1.5MB +3.0B

page load bundle size

id before after diff
triggersActionsUi 144.9KB 145.7KB +799.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added a commit that referenced this pull request Oct 29, 2020
@gmmorris
added alerting to app directory (#81902) (#81999)
2b8bd6d 
Adds a link to the  Alerts & Actions from the app directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ymao1 ymao1 ymao1 approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

No one assigned

Labels

Feature:Alerting release_note:enhancement Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Alerting app to the App Directory

5 participants

@gmmorris @elasticmachine @kibanamachine @ymao1 @YulNaumenko