Skip to content

[Security_Solution][Resolver] Promote z-index on node labels #80854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

[Security_Solution][Resolver] Promote z-index on node labels #80854

merged 1 commit into from
Oct 16, 2020

Conversation

@bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Oct 16, 2020 •
edited
Loading

Summary

Promoting node elements further in the stacking order to make sure stacking order is not determined by source order in cases where there may be overlap.

image

For maintainers

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 16, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bkimmel bkimmel marked this pull request as ready for review October 16, 2020 17:56
@bkimmel bkimmel requested review from a team as code owners October 16, 2020 17:56
@bkimmel bkimmel added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team Feature:Resolver Security Solution Resolver feature labels Oct 16, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 16, 2020

Pinging @elastic/endpoint-app-team (Feature:Resolver)

@michaelolo24
Copy link
Contributor

michaelolo24 commented Oct 16, 2020

I wonder if you can have a fade out effect in place of an ellipsis for when the pill is beneath the node label?

jonathan-buttner
jonathan-buttner approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there's a scenario where another node's name button could completely cover a related event button even at 100% zoom? I guess you could still access the related event by clicking the node and looking at the panel though...

@bkimmel
Copy link
Contributor Author

bkimmel commented Oct 16, 2020

Do you think there's a scenario where another node's name button could completely cover a related event button even at 100% zoom? I guess you could still access the related event by clicking the node and looking at the panel though...

@jonathan-buttner At 100% zoom, there's no overlap. Overlap only occurs when it is zoomed out between the default zoom level and the point at which the pills/submenu disappears. The pill box width is restricted to a value that won't allow that much overlap.

@bkimmel bkimmel merged commit 9edae0c into elastic:master Oct 16, 2020
@bkimmel bkimmel deleted the resolver/stacking-promote-node-over-pills branch October 16, 2020 18:06
@jonathan-buttner
Copy link
Contributor

jonathan-buttner commented Oct 16, 2020

Do you think there's a scenario where another node's name button could completely cover a related event button even at 100% zoom? I guess you could still access the related event by clicking the node and looking at the panel though...

@jonathan-buttner At 100% zoom, there's no overlap. Overlap only occurs when it is zoomed out between the default zoom level and the point at which the pills/submenu disappears. The pill box width is restricted to a value that won't allow that much overlap.

Oh right, that makes sense 👍

gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 19, 2020
@gmmorris
Merge branch 'master' into task-manager/refactor-oversized-class
c30d71b 
* master: (43 commits)
  [ML] Transforms: Fix tab ids for expanded row. (elastic#80666)
  server logs config paths to use for runner (elastic#52980)
  Fix audit logger logging to console even when disabled (elastic#80928)
  skip flaky suite (elastic#80929)
  Added Enterprise Search config to kibana-docker (elastic#80872)
  skip flaky suite (elastic#80914)
  [keystore_cli] parse values as JSON before adding to keystore (elastic#80848)
  [Ingest Manager] Fix for comparing versions with -SNAPSHOT suffix (elastic#80742)
  ECS audit logging (elastic#74640)
  [Uptime] Add client-side unit tests for remaining synthetics code (elastic#80215)
  [Security_Solution][Resolver] Promote z-index on node labels (elastic#80854)
  Move renderHeaderActions back into mount useEffect + update tests (elastic#80861)
  [Reporting] Document Network Policy configuration (elastic#80431)
  [Reporting] Add contextual documentation for CSV Max Bytes setting (elastic#80782)
  Add catch for Enterprise Search sending back a 401 response instead of redirect (elastic#80757)
  [Actions] Back Button on Add Connector Flyout (elastic#80160)
  removing `kibana_datatable` in favor of `datatable`  (elastic#80548)
  [Alerting UI] Updating 'Add new' wording (elastic#80509)
  [Docs] Document Encrypted Saved Objects functionality. (elastic#80183)
  [Discover] fix auto-refresh (elastic#80635)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 19, 2020
@gmmorris
Merge branch 'master' into task-manager/health
12e52e6 
* master: (23 commits)
  [ML] Transforms: Fix tab ids for expanded row. (elastic#80666)
  server logs config paths to use for runner (elastic#52980)
  Fix audit logger logging to console even when disabled (elastic#80928)
  skip flaky suite (elastic#80929)
  Added Enterprise Search config to kibana-docker (elastic#80872)
  skip flaky suite (elastic#80914)
  [keystore_cli] parse values as JSON before adding to keystore (elastic#80848)
  [Ingest Manager] Fix for comparing versions with -SNAPSHOT suffix (elastic#80742)
  ECS audit logging (elastic#74640)
  [Uptime] Add client-side unit tests for remaining synthetics code (elastic#80215)
  [Security_Solution][Resolver] Promote z-index on node labels (elastic#80854)
  Move renderHeaderActions back into mount useEffect + update tests (elastic#80861)
  [Reporting] Document Network Policy configuration (elastic#80431)
  [Reporting] Add contextual documentation for CSV Max Bytes setting (elastic#80782)
  Add catch for Enterprise Search sending back a 401 response instead of redirect (elastic#80757)
  [Actions] Back Button on Add Connector Flyout (elastic#80160)
  removing `kibana_datatable` in favor of `datatable`  (elastic#80548)
  [Alerting UI] Updating 'Add new' wording (elastic#80509)
  [Docs] Document Encrypted Saved Objects functionality. (elastic#80183)
  [Discover] fix auto-refresh (elastic#80635)
  ...
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 20, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 80854 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 20, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 21, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 80854 or prevent reminders by adding the backport:skip label.

@jonathan-buttner jonathan-buttner mentioned this pull request Oct 21, 2020
Merged
jonathan-buttner pushed a commit to jonathan-buttner/kibana that referenced this pull request Oct 21, 2020
@bkimmel @jonathan-buttner
[Security_Solution][Resolver] Promote z-index on node labels (elastic…
5727481 
…#80854)
jonathan-buttner added a commit that referenced this pull request Oct 21, 2020
@jonathan-buttner @bkimmel
[Security_Solution][Resolver] Promote z-index on node labels (#80854) (…
2145fc3 
…#81374)

Co-authored-by: Brent Kimmel <bkimmel@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 21, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees

No one assigned

Labels

Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bkimmel @kibanamachine @elasticmachine @michaelolo24 @jonathan-buttner @MindyRS