[Lens] Split up dimension panel code #80423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
dej611
approved these changes
Oct 15, 2020
|
|
||
| // Time to replace | ||
| props.setState({ | ||
| ...props.state, |
There was a problem hiding this comment.
nit: can you use mergeLayer here?
Comment on lines
41
to
51
| if (supportedOperationsByField[operation.field]) { | ||
| supportedOperationsByField[operation.field]!.push(operation.operationType); | ||
| } else { | ||
| supportedOperationsByField[operation.field] = [operation.operationType]; | ||
| } | ||
|
|
||
| if (supportedFieldsByOperation[operation.operationType]) { | ||
| supportedFieldsByOperation[operation.operationType]!.push(operation.field); | ||
| } else { | ||
| supportedFieldsByOperation[operation.operationType] = [operation.field]; | ||
| } |
There was a problem hiding this comment.
nitpick: I always find a bit harder to read these conditionals that handles add or create in different ways. What about check the existence of the entry and just push?
supportedOperationsByField[operation.field] = supportedOperationsByField[operation.field] || [];
supportedOperationsByField[operation.field].push(operation.operationType);
supportedFieldsByOperation[operation.operationType] = supportedFieldsByOperation[operation.operationType] || [];
supportedFieldsByOperation[operation.operationType].push(operation.field);There was a problem hiding this comment.
I think I understand your point, but I'm not sure your proposal is more clear. I'm going to try using the spread operator, but maybe this is just as bad?
supportedFieldsByOperation[operation.operationType] = [
...(supportedFieldsByOperation[operation.operationType] ?? []),
operation.field,
];
| @@ -91,25 +90,29 @@ export function changeColumn<C extends IndexPatternColumn>({ | |||
| updatedColumn.label = oldColumn.label; | |||
| } | |||
|
|
|||
| const layer = { | |||
There was a problem hiding this comment.
This is used below with the spread operator: maybe it can be saved here?
const layer = state.layers[layerId];
flash1293
approved these changes
Oct 16, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
8 tasks
mbondyra
approved these changes
Oct 19, 2020
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Oct 19, 2020
* [Lens] Split up dimension panel code * Fix test failures * Style updates Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
wylieconlon
pushed a commit
that referenced
this pull request
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three main changes in this PR, all refactorings that I found important as part of creating a reference-based editor for operations:
layerobject instead ofcolumns. This lets us use different parts of the layer in the future.dimension_panelinto three files:a.
dimension_panelkeeps only the UI components, and only UI testsb.
droppabledeals with only dragging and dropping logic, including what happens on dropc.
operation_supportis the function which is used to show functions + fields in the panels. Splitting it into a separate file so that it can be mocked.Checklist