Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: Internalize vis editor URL state and implement rough UI-based undo/redo. #8019

Closed
wants to merge 1 commit into from
Closed

[WIP]: Internalize vis editor URL state and implement rough UI-based undo/redo. #8019

wants to merge 1 commit into from

Commits on Aug 18, 2016

  1. Internalize vis editor URL state and implement rough UI-based undo/redo. 

    - When a visualization is loaded via deep-link, state.js removes the vis state from the URL and stores it internally.
- share_object_url directive surfaces shareable URL (but has bugs).
- Undo/redo works via buttons in editor sidebar (needs styles).
- Unaddressed major edge case: using the history back button to navigate back to a visualization results in a default, empty visualization.
    @cjcenizal
    cjcenizal committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    f547685 View commit details
    Browse the repository at this point in the history