Skip to content

[ML] Sending secondary auth headers to _explain #79814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

[ML] Sending secondary auth headers to _explain #79814

merged 1 commit into from
Oct 7, 2020

Conversation

@jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Oct 7, 2020 •
edited by tylersmalley
Loading

_explain endpoint requires secondary authentication headers.
Relates to elastic/elasticsearch#63281
Closes #79777

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review :ml v8.0.0 Feature:Data Frame Analytics ML data frame analytics features v7.10.0 labels Oct 7, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner October 7, 2020 06:09
@jgowdyelastic jgowdyelastic self-assigned this Oct 7, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 7, 2020

Pinging @elastic/ml-ui (:ml)

@tylersmalley tylersmalley mentioned this pull request Oct 7, 2020
Closed
tylersmalley
tylersmalley approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylersmalley
Copy link
Contributor

tylersmalley commented Oct 7, 2020

Feel free to include the revert of the skipped test here, or I can push the revert tomorrow.

@tylersmalley tylersmalley mentioned this pull request Oct 7, 2020
Merged
darnautov
darnautov approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 7, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 57f6ecd into elastic:master Oct 7, 2020
@jgowdyelastic jgowdyelastic deleted the sending-secondary-auth-headers-to-_explain branch October 7, 2020 08:00
@jgowdyelastic jgowdyelastic mentioned this pull request Oct 7, 2020
Merged
jgowdyelastic added a commit that referenced this pull request Oct 7, 2020
@jgowdyelastic
[ML] Sending secondary auth headers to _explain (#79814) (#79820)
2779396
@tylersmalley tylersmalley mentioned this pull request Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darnautov darnautov darnautov approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

+1 more reviewer

@tylersmalley tylersmalley tylersmalley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jgowdyelastic jgowdyelastic

Labels

bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix review v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

5 participants

@jgowdyelastic @elasticmachine @tylersmalley @kibanamachine @darnautov